You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/18 10:05:10 UTC
[GitHub] [flink] azagrebin commented on a change in pull request #8181:
[FLINK-12199][network] Refactor IOMetrics to not distinguish between
local/remote in/out bytes
azagrebin commented on a change in pull request #8181: [FLINK-12199][network] Refactor IOMetrics to not distinguish between local/remote in/out bytes
URL: https://github.com/apache/flink/pull/8181#discussion_r276599349
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -108,7 +110,7 @@ public RemoteInputChannel(
ResultPartitionID partitionId,
ConnectionID connectionId,
ConnectionManager connectionManager,
- TaskIOMetricGroup metrics) {
+ ProxyMetricGroup metrics) {
Review comment:
I would suggest creating `TaskNetworkMetrics` internally in for `NetworkEnviroment` (now in `registerTask`) and create/register all metrics there, similar to how it is done in `TaskIOMetricGroup`. Then pass only what is needed to gate and channels. This way we could keep metrics concern separately. All aggregating gauges from `TaskIOMetricGroup.initializeBufferMetrics` could be also moved from `TaskIOMetricGroup` into `TaskNetworkMetrics` (separate commit or PR for FLINK-12202).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services