You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/11/23 13:12:50 UTC
(commons-dbutils) branch master updated (1b71a61 -> c3a913f)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbutils.git
from 1b71a61 Encapsulate test fields (#222)
new 28109d4 Enable Checkstyle for tests
new c3a913f Encapsulate test fields #222
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
pom.xml | 2 +-
src/changes/changes.xml | 1 +
.../org/apache/commons/dbutils/handlers/ColumnListHandlerTest.java | 1 -
.../java/org/apache/commons/dbutils/handlers/KeyedHandlerTest.java | 1 -
.../commons/dbutils/handlers/columns/BooleanColumnHandlerTest.java | 4 ++--
.../commons/dbutils/handlers/columns/ByteColumnHandlerTest.java | 4 ++--
.../commons/dbutils/handlers/columns/DoubleColumnHandlerTest.java | 4 ++--
.../commons/dbutils/handlers/columns/FloatColumnHandlerTest.java | 4 ++--
8 files changed, 10 insertions(+), 11 deletions(-)
(commons-dbutils) 02/02: Encapsulate test fields #222
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbutils.git
commit c3a913f6b39ed74403858d25fbb56dd8b23c7a13
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Nov 23 08:12:46 2023 -0500
Encapsulate test fields #222
---
src/changes/changes.xml | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 790ed98..44d520b 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -46,6 +46,7 @@ The <action> type attribute can be add,update,fix,remove.
<release version="1.9.0" date="20YY-MM-DD" description="New features and bug fixes.">
<!-- FIX -->
<action dev="ggregory" type="update" due-to="sanjanarampurkottur01, Gary Gregory">Switch on String instead of cascading if-else in MockResultSet #220.</action>
+ <action dev="ggregory" type="update" due-to="sanjanarampurkottur01, Gary Gregory">Encapsulate test fields #222.</action>
<!-- ADD -->
<!-- UPDATE -->
<action dev="ggregory" type="update" due-to="Gary Gregory">Bump Java from 8 to 11.</action>
(commons-dbutils) 01/02: Enable Checkstyle for tests
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-dbutils.git
commit 28109d4103390b2056831b938a0bb7e7998da939
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Nov 23 08:12:37 2023 -0500
Enable Checkstyle for tests
Fix import order
---
pom.xml | 2 +-
.../org/apache/commons/dbutils/handlers/ColumnListHandlerTest.java | 1 -
.../java/org/apache/commons/dbutils/handlers/KeyedHandlerTest.java | 1 -
.../commons/dbutils/handlers/columns/BooleanColumnHandlerTest.java | 4 ++--
.../commons/dbutils/handlers/columns/ByteColumnHandlerTest.java | 4 ++--
.../commons/dbutils/handlers/columns/DoubleColumnHandlerTest.java | 4 ++--
.../commons/dbutils/handlers/columns/FloatColumnHandlerTest.java | 4 ++--
7 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/pom.xml b/pom.xml
index e0c9dd1..f4d8392 100644
--- a/pom.xml
+++ b/pom.xml
@@ -279,7 +279,7 @@
<configLocation>${checkstyle.config.file}</configLocation>
<enableRulesSummary>false</enableRulesSummary>
<headerLocation>${checkstyle.header.file}</headerLocation>
- <includeTestSourceDirectory>false</includeTestSourceDirectory> <!-- TODO -->
+ <includeTestSourceDirectory>true</includeTestSourceDirectory> <!-- TODO -->
<suppressionsLocation>${basedir}/src/conf/checkstyle/checkstyle-suppressions.xml</suppressionsLocation>
<suppressionsFileExpression>${basedir}/src/conf/checkstyle/checkstyle-suppressions.xml</suppressionsFileExpression>
</configuration>
diff --git a/src/test/java/org/apache/commons/dbutils/handlers/ColumnListHandlerTest.java b/src/test/java/org/apache/commons/dbutils/handlers/ColumnListHandlerTest.java
index 2f4d88e..e2d45a7 100644
--- a/src/test/java/org/apache/commons/dbutils/handlers/ColumnListHandlerTest.java
+++ b/src/test/java/org/apache/commons/dbutils/handlers/ColumnListHandlerTest.java
@@ -16,7 +16,6 @@
*/
package org.apache.commons.dbutils.handlers;
-import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.List;
diff --git a/src/test/java/org/apache/commons/dbutils/handlers/KeyedHandlerTest.java b/src/test/java/org/apache/commons/dbutils/handlers/KeyedHandlerTest.java
index b5e0b26..803b0e4 100644
--- a/src/test/java/org/apache/commons/dbutils/handlers/KeyedHandlerTest.java
+++ b/src/test/java/org/apache/commons/dbutils/handlers/KeyedHandlerTest.java
@@ -18,7 +18,6 @@ package org.apache.commons.dbutils.handlers;
import static org.mockito.Mockito.mock;
-import java.sql.ResultSet;
import java.sql.SQLException;
import java.util.Map;
import java.util.Map.Entry;
diff --git a/src/test/java/org/apache/commons/dbutils/handlers/columns/BooleanColumnHandlerTest.java b/src/test/java/org/apache/commons/dbutils/handlers/columns/BooleanColumnHandlerTest.java
index 9a50041..8803106 100644
--- a/src/test/java/org/apache/commons/dbutils/handlers/columns/BooleanColumnHandlerTest.java
+++ b/src/test/java/org/apache/commons/dbutils/handlers/columns/BooleanColumnHandlerTest.java
@@ -19,12 +19,12 @@ package org.apache.commons.dbutils.handlers.columns;
import static org.junit.Assert.assertEquals;
import static org.mockito.Mockito.when;
+import java.sql.ResultSet;
+
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.junit.MockitoJUnitRunner;
-import java.sql.ResultSet;
-
@RunWith(MockitoJUnitRunner.class)
public class BooleanColumnHandlerTest extends AbstractTestColumnHandler<Boolean> {
diff --git a/src/test/java/org/apache/commons/dbutils/handlers/columns/ByteColumnHandlerTest.java b/src/test/java/org/apache/commons/dbutils/handlers/columns/ByteColumnHandlerTest.java
index efe1b15..155ad68 100644
--- a/src/test/java/org/apache/commons/dbutils/handlers/columns/ByteColumnHandlerTest.java
+++ b/src/test/java/org/apache/commons/dbutils/handlers/columns/ByteColumnHandlerTest.java
@@ -19,12 +19,12 @@ package org.apache.commons.dbutils.handlers.columns;
import static org.junit.Assert.assertEquals;
import static org.mockito.Mockito.when;
+import java.sql.ResultSet;
+
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.junit.MockitoJUnitRunner;
-import java.sql.ResultSet;
-
@RunWith(MockitoJUnitRunner.class)
public class ByteColumnHandlerTest extends AbstractTestColumnHandler<Byte> {
diff --git a/src/test/java/org/apache/commons/dbutils/handlers/columns/DoubleColumnHandlerTest.java b/src/test/java/org/apache/commons/dbutils/handlers/columns/DoubleColumnHandlerTest.java
index 92eed1f..aa61e93 100644
--- a/src/test/java/org/apache/commons/dbutils/handlers/columns/DoubleColumnHandlerTest.java
+++ b/src/test/java/org/apache/commons/dbutils/handlers/columns/DoubleColumnHandlerTest.java
@@ -19,12 +19,12 @@ package org.apache.commons.dbutils.handlers.columns;
import static org.junit.Assert.assertEquals;
import static org.mockito.Mockito.when;
+import java.sql.ResultSet;
+
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.junit.MockitoJUnitRunner;
-import java.sql.ResultSet;
-
@RunWith(MockitoJUnitRunner.class)
public class DoubleColumnHandlerTest extends AbstractTestColumnHandler<Double> {
diff --git a/src/test/java/org/apache/commons/dbutils/handlers/columns/FloatColumnHandlerTest.java b/src/test/java/org/apache/commons/dbutils/handlers/columns/FloatColumnHandlerTest.java
index 61c35d1..3ebddc2 100644
--- a/src/test/java/org/apache/commons/dbutils/handlers/columns/FloatColumnHandlerTest.java
+++ b/src/test/java/org/apache/commons/dbutils/handlers/columns/FloatColumnHandlerTest.java
@@ -19,12 +19,12 @@ package org.apache.commons.dbutils.handlers.columns;
import static org.junit.Assert.assertEquals;
import static org.mockito.Mockito.when;
+import java.sql.ResultSet;
+
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.junit.MockitoJUnitRunner;
-import java.sql.ResultSet;
-
@RunWith(MockitoJUnitRunner.class)
public class FloatColumnHandlerTest extends AbstractTestColumnHandler<Float> {