[GitHub] [lucene-solr] HoustonPutman opened a new pull request #984: SOLR-12217: Support shards.preference for individual shard requests

[GitBox <gi...@apache.org>]

HoustonPutman opened a new pull request #984: SOLR-12217: Support shards.preference for individual shard requests
URL: https://github.com/apache/lucene-solr/pull/984
 
 
   # Description
   
   Use shard preference rules when choosing replicas to send individual shard requests. This includes requests from SolrJ as well as requests sent via streaming expressions.
   
   # Solution
   How routing preferences are determined:
   
   For Streaming Expressions, it will use the preferences from the following sources, in order of preference (defaults last):
   1. The params given in the stream source
   1. The URL params sent in the streaming request
   1. The `DEFAULT_SHARD_PREFERENCES` set in cluster properties
   
   For SolrJ, it will use the preferences from the params of the request it is sending.
   
   # Tests
   
   Current tests pass.
   
   **TODO** Add tests for routing functionality
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request title.
   - [ ] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute.
   - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [ ] I have developed this patch against the `master` branch.
   - [ ] I have run `ant precommit` and the appropriate test suite.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org