You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "Saljack (via GitHub)" <gi...@apache.org> on 2026/06/05 17:13:45 UTC
[PR] Remember sort order of the file table in git diff view [netbeans]
Saljack opened a new pull request, #9430:
URL: https://github.com/apache/netbeans/pull/9430
I want to always sort files by path in Git Diff view. This stores the sort configuration of the table in the Git Diff view. It is inspired by the same implementation in the subversion module.
Closes #7742
---
**^Add meaningful description above**
<details open>
<summary>Click to collapse/expand PR instructions</summary>
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
### PR approval and merge checklist:
1. [ ] Was this PR [correctly labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)), did the right tests run? When did they run?
2. [ ] Is this PR [squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)?
3. [ ] Are author name / email address correct? Are [co-authors](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line) correctly listed? Do the commit messages need updates?
3. [ ] Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?
If this PR targets the delivery branch: [don't merge](https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery). ([full wiki article](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide))
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remember sort order of the file table in git diff view [netbeans]
Posted by "Saljack (via GitHub)" <gi...@apache.org>.
Saljack commented on PR #9430:
URL: https://github.com/apache/netbeans/pull/9430#issuecomment-4733636789
@matthiasblaesing Updated. Now it stores on click on the table header, and there is a change in sort order. Storing on a close diff is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remember sort order of the file table in git diff view [netbeans]
Posted by "Saljack (via GitHub)" <gi...@apache.org>.
Saljack commented on PR #9430:
URL: https://github.com/apache/netbeans/pull/9430#issuecomment-4729512429
@matthiasblaesing Thanks for your review. I did not realize that this table is used for general git diffs. I wanted mainly sorted files in Git Commit Diff view. Where you can have only one instance of the table.
image
<img width="1294" height="609" alt="image" src="https://github.com/user-attachments/assets/c4b0fda9-44b2-467d-9dd3-918f81b3f0ba" />
Let me check it and fix it.
Can you point where that can be found? I was not able to find it.
https://github.com/apache/netbeans/blob/master/ide/subversion/src/org/netbeans/modules/subversion/ui/commit/CommitTable.java#L195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remember sort order of the file table in git diff view [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing merged PR #9430:
URL: https://github.com/apache/netbeans/pull/9430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remember sort order of the file table in git diff view [netbeans]
Posted by "Saljack (via GitHub)" <gi...@apache.org>.
Saljack commented on PR #9430:
URL: https://github.com/apache/netbeans/pull/9430#issuecomment-4761449400
Fixed author and commiter name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remember sort order of the file table in git diff view [netbeans]
Posted by "poledny-fiskaly (via GitHub)" <gi...@apache.org>.
poledny-fiskaly commented on PR #9430:
URL: https://github.com/apache/netbeans/pull/9430#issuecomment-4729470556
@matthiasblaesing Thanks for your review. I did not realize that this table is used for general git diffs. I wanted mainly sorted files in Git Commit Diff view. Where you can have only one instance of the table.
<img width="1294" height="609" alt="image" src="https://github.com/user-attachments/assets/c45d34d8-a6ea-4d15-876f-85f86c115e4d" />
Let me check it and fix it.
> Can you point where that can be found? I was not able to find it.
https://github.com/apache/netbeans/blob/master/ide/subversion/src/org/netbeans/modules/subversion/ui/commit/CommitTable.java#L195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remember sort order of the file table in git diff view [netbeans]
Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #9430:
URL: https://github.com/apache/netbeans/pull/9430#issuecomment-4698935421
I had a quick look and initially though that it did not work. I opened a testrun with this, changed sorting, closed IDE and reopened. The state was not persistet. Looking at the implementation i then saw that sorting is stored when the diff is closed. This seems counter intuitive. Consider this event order:
1. Open two diffs
2. Change the sort order in the first view
3. Change the sort order in the second view
4. Close the second view
5. Close the first view
I would expect that the last setting survives, but in this case it is the first one.
> It is inspired by the same implementation in the subversion module.
Can you point where that can be found? I was not able to find it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists