You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mgaido91 <gi...@git.apache.org> on 2017/12/06 10:15:25 UTC

[GitHub] spark pull request #19908: [SPARK-22696][SQL] objects functions should not u...

GitHub user mgaido91 opened a pull request:

    https://github.com/apache/spark/pull/19908

    [SPARK-22696][SQL] objects functions should not use unneeded global variables

    ## What changes were proposed in this pull request?
    
    Some objects functions are using global variables which are not needed. This can generate some unneeded entries in the constant pool.
    
    The PR replaces the unneeded global variables with local variables.
    
    ## How was this patch tested?
    
    added UTs


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mgaido91/spark SPARK-22696

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/19908.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #19908
    
----
commit f5be83641627ff58dc9508e2d45b3e76ca333c75
Author: Marco Gaido <mg...@hortonworks.com>
Date:   2017-12-06T09:17:36Z

    [SPARK-22696][SQL] objects functions should not use unneeded global variables

commit a33bd995524d82af514594cefc66dbebf2d559f0
Author: Marco Gaido <mg...@hortonworks.com>
Date:   2017-12-06T10:13:52Z

    Merge branch 'master' of github.com:apache/spark into SPARK-22696

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19908: [SPARK-22696][SQL] objects functions should not use unne...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19908
  
    **[Test build #84571 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84571/testReport)** for PR 19908 at commit [`e7cdbd7`](https://github.com/apache/spark/commit/e7cdbd7672defbe4a4e54e097c70df141f578781).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19908: [SPARK-22696][SQL] objects functions should not use unne...

Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/19908
  
    thanks, merging to master!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19908: [SPARK-22696][SQL] objects functions should not use unne...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19908
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84548/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19908: [SPARK-22696][SQL] objects functions should not use unne...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19908
  
    **[Test build #84571 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84571/testReport)** for PR 19908 at commit [`e7cdbd7`](https://github.com/apache/spark/commit/e7cdbd7672defbe4a4e54e097c70df141f578781).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19908: [SPARK-22696][SQL] objects functions should not use unne...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19908
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19908: [SPARK-22696][SQL] objects functions should not use unne...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19908
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84571/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19908: [SPARK-22696][SQL] objects functions should not use unne...

Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:

    https://github.com/apache/spark/pull/19908
  
    @cloud-fan @kiszk @viirya may you please review this? Thanks


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19908: [SPARK-22696][SQL] objects functions should not use unne...

Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/19908
  
    LGTM


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19908: [SPARK-22696][SQL] objects functions should not use unne...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19908
  
    **[Test build #84548 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84548/testReport)** for PR 19908 at commit [`a33bd99`](https://github.com/apache/spark/commit/a33bd995524d82af514594cefc66dbebf2d559f0).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:
      * `    case class ReqAndHandler(req: Request, handler: MemberHandler)`
      * `trait TypeCoercionRule extends Rule[LogicalPlan] with Logging `
      * `case class AnalysisBarrier(child: LogicalPlan) extends LeafNode `


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #19908: [SPARK-22696][SQL] objects functions should not u...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/19908


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19908: [SPARK-22696][SQL] objects functions should not use unne...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/19908
  
    **[Test build #84548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/84548/testReport)** for PR 19908 at commit [`a33bd99`](https://github.com/apache/spark/commit/a33bd995524d82af514594cefc66dbebf2d559f0).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #19908: [SPARK-22696][SQL] objects functions should not use unne...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/19908
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org