You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ilya Pronin <ip...@twopensource.com> on 2017/08/31 15:29:20 UTC
Review Request 62016: Fixed unnecessary non-constness.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62016/
-----------------------------------------------------------
Review request for mesos and Alexander Rojas.
Repository: mesos
Description
-------
Const `Owned` doesn't make the underlying pointer const.
Diffs
-----
3rdparty/libprocess/src/process.cpp dcd9c6738816764aae066fe56cd5f468c98fc9bd
Diff: https://reviews.apache.org/r/62016/diff/1/
Testing
-------
`make check`
Thanks,
Ilya Pronin
Re: Review Request 62016: Fixed unnecessary non-constness.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62016/#review184276
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On Aug. 31, 2017, 5:29 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62016/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2017, 5:29 p.m.)
>
>
> Review request for mesos and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Const `Owned` doesn't make the underlying pointer const.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp dcd9c6738816764aae066fe56cd5f468c98fc9bd
>
>
> Diff: https://reviews.apache.org/r/62016/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 62016: Fixed unnecessary non-constness.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62016/#review184294
-----------------------------------------------------------
Bad patch!
Reviews applied: [62016]
Logs available here: http://104.210.40.105/logs/master/62016
- Mesos Reviewbot Windows
On Aug. 31, 2017, 3:29 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62016/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2017, 3:29 p.m.)
>
>
> Review request for mesos and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Const `Owned` doesn't make the underlying pointer const.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp dcd9c6738816764aae066fe56cd5f468c98fc9bd
>
>
> Diff: https://reviews.apache.org/r/62016/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Ilya Pronin
>
>