You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2021/10/12 05:57:01 UTC

[GitHub] [samza] carldea opened a new pull request #1545: Using TCK Tested JDK builds of OpenJDK

carldea opened a new pull request #1545:
URL: https://github.com/apache/samza/pull/1545


   The AdoptOpenJDK has been discontinued since July 2021 (https://adoptopenjdk.net). Switching the distribution to Azul Zulu. When using Zulu you get all the latest updated (TCK Tested) builds for all versions of OpenJDK. 
   
   Also added is a fixed (major) release version(s) such as `JDK 8.0.192`. This is often a good practice whenever a build/test triggers (push/pull events) to help determine if the latest (`JDK 8`) had failed the from the **latest build** vs something in **your code** caused (or introduced). 
   
   **For example**, when building with `JDK 8.0.192` (fixed version) the build/tests passes (Green) and JDK 8 fails (Red) will mean that the latest `JDK 8` was the cause and not your code. 
   
   **Note:** Other distributions such as Temurin do not support archived fixed releases prior to Sept. 2021 and many non LTS (long term support) releases if you plan to try out newer features in the language.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] mynameborat commented on pull request #1545: Using TCK Tested JDK builds of OpenJDK

Posted by GitBox <gi...@apache.org>.
mynameborat commented on pull request #1545:
URL: https://github.com/apache/samza/pull/1545#issuecomment-941192047


   @bringhurst would you mind taking a pass on this change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] bringhurst commented on pull request #1545: Using TCK Tested JDK builds of OpenJDK

Posted by GitBox <gi...@apache.org>.
bringhurst commented on pull request #1545:
URL: https://github.com/apache/samza/pull/1545#issuecomment-944406088






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] bringhurst edited a comment on pull request #1545: Using TCK Tested JDK builds of OpenJDK

Posted by GitBox <gi...@apache.org>.
bringhurst edited a comment on pull request #1545:
URL: https://github.com/apache/samza/pull/1545#issuecomment-944406088


   @mynameborat +1 on this. Given the options at https://github.com/actions/setup-java, this seems like the best way to go imo.
   
   The core Samza team also has much more experience with Zulu (versus Temurin).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] mynameborat commented on pull request #1545: Using TCK Tested JDK builds of OpenJDK

Posted by GitBox <gi...@apache.org>.
mynameborat commented on pull request #1545:
URL: https://github.com/apache/samza/pull/1545#issuecomment-941192047


   @bringhurst would you mind taking a pass on this change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [samza] mynameborat merged pull request #1545: Using TCK Tested JDK builds of OpenJDK

Posted by GitBox <gi...@apache.org>.
mynameborat merged pull request #1545:
URL: https://github.com/apache/samza/pull/1545


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org