You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "sollhui (via GitHub)" <gi...@apache.org> on 2024/07/03 15:05:20 UTC
[PR] [fix](cloud) add lock when get visible version [doris]
sollhui opened a new pull request, #37246:
URL: https://github.com/apache/doris/pull/37246
## Proposed changes
introduced by https://github.com/apache/doris/pull/34615
When get visible version from cache, the visible version may be updated by load, so it is necessary to add lock when get visible version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) add lock when get visible version [doris]
Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui commented on PR #37246:
URL: https://github.com/apache/doris/pull/37246#issuecomment-2206458881
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) add lock when get visible version from cache [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37246:
URL: https://github.com/apache/doris/pull/37246#issuecomment-2206725332
<details>
<summary>TPC-H: <b>Total hot run time: 39724 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8d70acbb340655c0fb7789fdc6b6dd13d00d00a4, data reload: false
------ Round 1 ----------------------------------
q1 17616 4283 4260 4260
q2 2021 200 194 194
q3 10437 1147 1097 1097
q4 10191 844 727 727
q5 7544 2656 2631 2631
q6 217 135 137 135
q7 960 612 599 599
q8 9226 2043 2081 2043
q9 8959 6492 6489 6489
q10 9004 3678 3715 3678
q11 446 234 234 234
q12 503 232 223 223
q13 18768 2978 2959 2959
q14 263 219 217 217
q15 528 485 491 485
q16 521 383 364 364
q17 970 639 690 639
q18 7944 7452 7407 7407
q19 4535 1531 1489 1489
q20 657 318 326 318
q21 4855 3952 3200 3200
q22 391 342 336 336
Total cold run time: 116556 ms
Total hot run time: 39724 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4357 4210 4215 4210
q2 382 255 260 255
q3 2959 2828 2865 2828
q4 1975 1764 1697 1697
q5 5639 5489 5483 5483
q6 219 130 139 130
q7 2195 1818 1876 1818
q8 3304 3391 3384 3384
q9 8713 8651 8857 8651
q10 4092 3913 3679 3679
q11 592 522 501 501
q12 866 678 632 632
q13 17371 3179 3169 3169
q14 317 280 291 280
q15 523 475 473 473
q16 486 433 447 433
q17 1825 1554 1512 1512
q18 8187 7987 7676 7676
q19 2322 1679 1655 1655
q20 2087 1891 1839 1839
q21 5136 4888 4697 4697
q22 623 570 550 550
Total cold run time: 74170 ms
Total hot run time: 55552 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) add lock when get visible version from cache [doris]
Posted by "sollhui (via GitHub)" <gi...@apache.org>.
sollhui closed pull request #37246: [fix](cloud) add lock when get visible version from cache
URL: https://github.com/apache/doris/pull/37246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) add lock when get visible version from cache [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37246:
URL: https://github.com/apache/doris/pull/37246#issuecomment-2206744219
<details>
<summary>TPC-DS: <b>Total hot run time: 172062 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8d70acbb340655c0fb7789fdc6b6dd13d00d00a4, data reload: false
query1 908 387 382 382
query2 6457 2498 2366 2366
query3 6638 205 211 205
query4 18891 17605 17260 17260
query5 3659 497 484 484
query6 251 184 165 165
query7 4597 304 299 299
query8 310 295 298 295
query9 8478 2465 2457 2457
query10 583 313 285 285
query11 10637 10011 10073 10011
query12 114 87 83 83
query13 1641 371 369 369
query14 10266 6437 7399 6437
query15 235 193 188 188
query16 7787 321 311 311
query17 1571 544 542 542
query18 1964 283 280 280
query19 201 156 155 155
query20 89 82 83 82
query21 211 130 130 130
query22 4280 4140 3960 3960
query23 34013 33585 33478 33478
query24 11148 2877 2800 2800
query25 640 385 392 385
query26 1345 160 159 159
query27 3027 324 327 324
query28 7583 2195 2173 2173
query29 907 629 649 629
query30 256 155 153 153
query31 955 750 737 737
query32 99 54 54 54
query33 747 290 288 288
query34 990 470 480 470
query35 742 614 692 614
query36 1124 981 948 948
query37 156 78 79 78
query38 2932 2898 2831 2831
query39 911 832 850 832
query40 213 128 131 128
query41 52 52 54 52
query42 122 103 106 103
query43 589 561 562 561
query44 1175 751 742 742
query45 189 161 171 161
query46 1082 700 690 690
query47 1830 1783 1754 1754
query48 367 307 291 291
query49 849 406 429 406
query50 776 383 380 380
query51 7019 6749 6721 6721
query52 107 91 95 91
query53 365 284 291 284
query54 905 439 447 439
query55 77 74 75 74
query56 285 263 265 263
query57 1138 1066 1076 1066
query58 259 254 259 254
query59 3381 3209 3158 3158
query60 296 284 298 284
query61 96 96 93 93
query62 613 469 444 444
query63 322 290 289 289
query64 8828 2303 1762 1762
query65 3165 3123 3096 3096
query66 744 318 331 318
query67 15523 15002 14856 14856
query68 4796 532 542 532
query69 619 448 311 311
query70 1206 1138 1094 1094
query71 494 277 273 273
query72 7274 5237 5612 5237
query73 756 325 321 321
query74 5924 5513 5481 5481
query75 3791 2605 2705 2605
query76 3516 987 994 987
query77 613 304 301 301
query78 9605 8960 8818 8818
query79 3224 508 498 498
query80 2518 481 463 463
query81 584 221 224 221
query82 1319 112 107 107
query83 301 183 170 170
query84 277 88 91 88
query85 1635 280 273 273
query86 492 313 305 305
query87 3284 3055 3045 3045
query88 4832 2441 2402 2402
query89 492 395 403 395
query90 1925 188 190 188
query91 129 100 101 100
query92 65 51 49 49
query93 4373 516 514 514
query94 1313 210 213 210
query95 416 322 316 316
query96 600 277 271 271
query97 3201 3006 3044 3006
query98 212 211 200 200
query99 1171 822 852 822
Total cold run time: 278667 ms
Total hot run time: 172062 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) add lock when get visible version [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37246:
URL: https://github.com/apache/doris/pull/37246#issuecomment-2206458387
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cloud) add lock when get visible version from cache [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #37246:
URL: https://github.com/apache/doris/pull/37246#issuecomment-2206753140
<details>
<summary>ClickBench: <b>Total hot run time: 29.98 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8d70acbb340655c0fb7789fdc6b6dd13d00d00a4, data reload: false
query1 0.04 0.04 0.03
query2 0.08 0.04 0.04
query3 0.23 0.04 0.05
query4 1.69 0.07 0.07
query5 0.50 0.48 0.48
query6 1.12 0.72 0.73
query7 0.02 0.01 0.01
query8 0.05 0.05 0.05
query9 0.55 0.49 0.48
query10 0.55 0.55 0.54
query11 0.15 0.12 0.11
query12 0.15 0.12 0.12
query13 0.60 0.59 0.58
query14 0.78 0.78 0.79
query15 0.85 0.82 0.80
query16 0.37 0.35 0.36
query17 0.98 0.95 0.97
query18 0.23 0.25 0.24
query19 1.83 1.69 1.78
query20 0.02 0.01 0.01
query21 15.38 0.77 0.66
query22 4.37 7.26 1.57
query23 18.28 1.51 1.21
query24 2.08 0.24 0.22
query25 0.15 0.08 0.09
query26 0.26 0.18 0.17
query27 0.08 0.08 0.07
query28 13.27 1.01 1.01
query29 12.58 3.27 3.23
query30 0.26 0.07 0.05
query31 2.84 0.39 0.40
query32 3.27 0.48 0.48
query33 2.92 2.90 2.91
query34 17.19 4.36 4.40
query35 4.49 4.45 4.49
query36 0.66 0.46 0.48
query37 0.19 0.16 0.16
query38 0.16 0.15 0.14
query39 0.04 0.03 0.04
query40 0.17 0.14 0.13
query41 0.10 0.05 0.05
query42 0.05 0.06 0.04
query43 0.05 0.04 0.03
Total cold run time: 109.63 s
Total hot run time: 29.98 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org