You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "d2r (GitHub)" <gi...@apache.org> on 2018/08/22 23:24:36 UTC
[GitHub] [trafficserver] d2r opened pull request #4151: Corrects IPv4
multicast ip address check
Requesting back-port to LTS branches because this is a bug that could affect stability/correctness.
Assuming 6.x will be retired, but we could back-port if needed.
Supersedes #4150
[ Full content available at: https://github.com/apache/trafficserver/pull/4151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficserver] d2r commented on pull request #4151:
Corrects IPv4 multicast ip address check
Posted by "d2r (GitHub)" <gi...@apache.org>.
Addressed.
[ Full content available at: https://github.com/apache/trafficserver/pull/4151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficserver] d2r commented on pull request #4151:
Corrects IPv4 multicast ip address check
Posted by "d2r (GitHub)" <gi...@apache.org>.
See [here](https://github.com/apache/trafficserver/blob/3fc04c4590d7e47ba648b06f973c874d6ff900fc/lib/ts/ink_inet.cc#L465) where we similarly shift 4 bits.
This is intended to compare `224.0.0.0/4`, the high 4 bits of an IPv4 [multicast address](https://en.wikipedia.org/wiki/Multicast_address#IPv4).
[ Full content available at: https://github.com/apache/trafficserver/pull/4151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficserver] d2r commented on pull request #4151:
Corrects IPv4 multicast ip address check
Posted by "d2r (GitHub)" <gi...@apache.org>.
Sure; I did the shift because [ink_inet.cc](https://github.com/apache/trafficserver/blob/3fc04c4590d7e47ba648b06f973c874d6ff900fc/lib/ts/ink_inet.cc#L465) did it that way, and I have no problem changing this PR if we'd rather mask.
[ Full content available at: https://github.com/apache/trafficserver/pull/4151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request
#4151: Corrects IPv4 multicast ip address check
Posted by "SolidWallOfCode (GitHub)" <gi...@apache.org>.
`0xE0 == *ats_ip_addr8_cast(ip) & 0xF0`?
[ Full content available at: https://github.com/apache/trafficserver/pull/4151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficserver] d2r commented on pull request #4151:
Corrects IPv4 multicast ip address check
Posted by "d2r (GitHub)" <gi...@apache.org>.
Agree. Will change it.
[ Full content available at: https://github.com/apache/trafficserver/pull/4151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficserver] d2r commented on pull request #4151:
Corrects IPv4 multicast ip address check
Posted by "d2r (GitHub)" <gi...@apache.org>.
Leaving it be, as we discussed in person.
[ Full content available at: https://github.com/apache/trafficserver/pull/4151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #4151:
Corrects IPv4 multicast ip address check
Posted by "bryancall (GitHub)" <gi...@apache.org>.
I would do `ats_ip_addr8_cast(ip)[0])` instead of `*ats_ip_addr8_cast(ip)` to show it is an array. It is done in another place in the code and it should be consistent.
[ Full content available at: https://github.com/apache/trafficserver/pull/4151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficserver] d2r commented on issue #4151: Corrects IPv4
multicast ip address check
Posted by "d2r (GitHub)" <gi...@apache.org>.
Confirmed with @SolidWallOfCode in person he is OK with the style change.
[ Full content available at: https://github.com/apache/trafficserver/pull/4151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [trafficserver] d2r closed pull request #4151: Corrects IPv4
multicast ip address check
Posted by "d2r (GitHub)" <gi...@apache.org>.
[ pull request closed by d2r ]
[ Full content available at: https://github.com/apache/trafficserver/pull/4151 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org