You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/18 03:51:21 UTC

[GitHub] [hudi] todd5167 commented on a diff in pull request #5202: [HUDI-3771] flink supports sync table information to aws glue

todd5167 commented on code in PR #5202:
URL: https://github.com/apache/hudi/pull/5202#discussion_r900692706


##########
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/ddl/HiveSyncMode.java:
##########
@@ -26,6 +26,10 @@
    * The HMS mode use the hive meta client to sync metadata.
    */
   HMS,
+  /**
+   * The GLUE mode use the glue client to sync metadata.
+   */
+  GLUE,

Review Comment:
   
   > The way of configuring glue sync tool should be fixed on flink side; instead of setting mode, it should be setting the sync tool class. Changing the enum confused users who were misled to set it but no effect when using spark.
   > 
   > @todd5167 can you make a fix for this?
   
   @xushiyan  In the future, I will change the synchronization Glue judgment condition to judgment through CatalogSyncToolClass, and the HiveSyncMode is still HMS.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org