You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/12/15 14:50:50 UTC

[GitHub] DennisKonrad commented on issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to host on connection termination to console

DennisKonrad commented on issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to host on connection termination to console
URL: https://github.com/apache/cloudstack/pull/1269#issuecomment-447573860
 
 
   Is it reasonable to block a merge on this because of a coding style disagreement? Also I agree with @anshul1886 that it seems to make the code harder to understand if one would create a helper function because of five line of duplicated code. 
   
   Especially because there is no obvious way to name the new function so it would make sense semantically. At least from my point of understanding.
   
   Maybe you have some suggestion on how to name the function? @GabrielBrascher

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services