[GitHub] [dubbo] aamingaa commented on a diff in pull request #11859: feat: add exception code

["aamingaa (via GitHub)" <gi...@apache.org>]

aamingaa commented on code in PR #11859:
URL: https://github.com/apache/dubbo/pull/11859#discussion_r1158682954


##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/call/ClientCall.java:
##########
@@ -53,7 +53,7 @@ interface Listener {
          * @param status   response status
          * @param trailers response trailers
          */
-        void onClose(TriRpcStatus status, Map<String, Object> trailers);
+        void onClose(TriRpcStatus status, Map<String, Object> trailers, Map<String, String> triExceptionCodeAttachments);

Review Comment:
   it is to make implementable



##########
dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/TripleHeaderEnum.java:
##########
@@ -70,6 +72,12 @@ public enum TripleHeaderEnum {
 
     }
 
+    public static Map<String, TripleHeaderEnum> needToDeliveryHeaders() {

Review Comment:
   containsNeedToDeliveryHeaders use it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org