[GitHub] [druid] 599166320 commented on a diff in pull request #13031: ScanQuery supports multi column orderBy queries

[GitBox <gi...@apache.org>]

599166320 commented on code in PR #13031:
URL: https://github.com/apache/druid/pull/13031#discussion_r966220104


##########
processing/src/main/java/org/apache/druid/query/scan/ScanQueryEngine.java:
##########
@@ -252,7 +260,295 @@ public void cleanup(Iterator<ScanResultValue> iterFromMake)
             ))
     );
   }
+  private Sequence<ScanResultValue> getScanOrderByResultValueSequence(

Review Comment:
   > 
   
   
   This is a good idea. Query engines should not be responsible for sorting. Let me see how to insert a "Sorting Query runner".
   
   I think that currently, orderby is implemented in a violent way. If we follow the  Druid pattern , the insertion and sorting position is not suitable.
   
   The current processing method is as follows:
   
   Segments are sorted in `ScanqueryEngine.process`.
   
   Data nodes are sorted in `ScanqueryRunnerFactory.mergeRunners`.
   
   The broker is sorted in `ScanqueryQueryToolCheck.mergeReults`
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org