[Bug 53924] New: [PATCH] support for retrieve-table-marker

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53924

          Priority: P2
            Bug ID: 53924
          Assignee: fop-dev@xmlgraphics.apache.org
           Summary: [PATCH] support for retrieve-table-marker
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: lmpmbernardo@gmail.com
          Hardware: All
            Status: NEW
           Version: 1.1dev
         Component: general
           Product: Fop

This patch adds support for retrieve-table-marker. The patch is extensive and
very likely there is room for improvement, but it does what it is supposed to
do and was tested with non trivial examples.

The implementation has a main constraint: the resolution of the
retrieve-table-marker element needs to be an element that does not change the
BPD of the containing cell. In practical terms this means that the height of
the table header or footer where the retrieve-table-marker element is placed
cannot change once the retrieve-table-marker is replaced by the resolved
content. In the end this is not a serious constraint since in most cases the
retrieve-table-marker element is meant to be replaced by a line of text (and
there is already adjacent text, or the height of the cell is specified).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53924] [PATCH] support for retrieve-table-marker

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53924

--- Comment #1 from Luis Bernardo <lm...@gmail.com> ---
Created attachment 29410
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29410&action=edit
patch

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53924] [PATCH] support for retrieve-table-marker

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53924

Mehdi Houshmand <me...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Mehdi Houshmand <me...@gmail.com> ---
Committed to r1391502. One thing to note, I haven't changed it this time
because I'm not very familiar with the layout are of code, but adding comments
like:
// mock
<then mocking something>
don't really add anything. It's obvious you're mocking, because you're using
the mock(...) method. Not a biggy, but just for next time.

Thanks for the work, keep it up!

Mehdi

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53924] [PATCH] support for retrieve-table-marker

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53924

--- Comment #2 from Luis Bernardo <lm...@gmail.com> ---
Created attachment 29411
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29411&action=edit
two extensive examples

two examples: include *.fo source and *.pdf output

-- 
You are receiving this mail because:
You are the assignee for the bug.