You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/07/04 00:45:03 UTC
[GitHub] [nifi] Lehel44 opened a new pull request, #6176: NIFI-9558: ConnectWebSocket leaks connections and duplicates FlowFile…
Lehel44 opened a new pull request, #6176:
URL: https://github.com/apache/nifi/pull/6176
…s in incoming connection mode (new PR)
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-9958](https://issues.apache.org/jira/browse/NIFI-9958)
ConnectWebsocket didn't close the previous session when a new one was created with custom http headers.
This PR fixes the issue, it'll close the previous connections and any data processing will be aborted.
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-9558) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] tpalfy commented on pull request #6176: NIFI-9558: ConnectWebSocket leaks connections and duplicates FlowFile…
Posted by GitBox <gi...@apache.org>.
tpalfy commented on PR #6176:
URL: https://github.com/apache/nifi/pull/6176#issuecomment-1175940276
LGTM
Thanks for your work @Lehel44.
Pushed to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] tpalfy commented on a diff in pull request #6176: NIFI-9558: ConnectWebSocket leaks connections and duplicates FlowFile…
Posted by GitBox <gi...@apache.org>.
tpalfy commented on code in PR #6176:
URL: https://github.com/apache/nifi/pull/6176#discussion_r913079846
##########
nifi-nar-bundles/nifi-websocket-bundle/nifi-websocket-processors/src/main/resources/docs/org.apache.nifi.processors.websocket.ConnectWebSocket/additionalDetails.html:
##########
@@ -35,7 +35,8 @@ <h2>Summary</h2>
<p>
You can define custom websocket headers in the incoming flowfile as additional attributes. The attribute key
shall start with "header." and continue with they header key. For example: "header.Authorization". The attribute
- value will be the corresponding header value.
+ value will be the corresponding header value. If a new flowfile is passed to the processor, the previous sessions will be closed,
Review Comment:
Can we please move this warning to the main description of the processor. It is an important aspect/limitation of the processor rather than a detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #6176: NIFI-9558: ConnectWebSocket leaks connections and duplicates FlowFile…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #6176: NIFI-9558: ConnectWebSocket leaks connections and duplicates FlowFile…
URL: https://github.com/apache/nifi/pull/6176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org