You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/11/12 02:57:40 UTC

[GitHub] [beam] udim commented on a change in pull request #13302: [BEAM-11211] Allow pyarrow up to 2.x, raise helpful error when trying to write wit…

udim commented on a change in pull request #13302:
URL: https://github.com/apache/beam/pull/13302#discussion_r521786274



##########
File path: sdks/python/apache_beam/io/parquetio.py
##########
@@ -506,6 +509,11 @@ def __init__(
         compression_type=CompressionTypes.UNCOMPRESSED)
     self._schema = schema
     self._codec = codec
+    if ARROW_MAJOR_VERSION == 1 and self._codec.lower() == "lz4":

Review comment:
       Technically a str, so:
   ```suggestion
       if ARROW_MAJOR_VERSION == '1' and self._codec.lower() == "lz4":
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org