You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/07/20 16:22:25 UTC

[GitHub] [trafficserver] shinrich commented on a change in pull request #7298: Adds OCSP support for BoringSSL

shinrich commented on a change in pull request #7298:
URL: https://github.com/apache/trafficserver/pull/7298#discussion_r673274246



##########
File path: iocore/net/OCSPStapling.cc
##########
@@ -20,11 +20,18 @@
  */
 
 #include "P_OCSPStapling.h"
+
 #if TS_USE_TLS_OCSP
 
 #include <openssl/bio.h>
 #include <openssl/ssl.h>
+
+#if TS_HAS_BORINGOCSP
+#include "boringocsp/ocsp.h"

Review comment:
       Are we assuming boringocsp/ocsp.h is in our tree?  Or why are we using double quotes instead of angle brackets here?  Not impacting functionality, but maybe confusing from the maintenance perspective.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org