You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Guanpeng Xu (JIRA)" <ji...@apache.org> on 2011/03/14 10:30:29 UTC
[jira] Created: (HBASE-3633) ZKUtil::createSetData should only
create a node when it nonexists
ZKUtil::createSetData should only create a node when it nonexists
-----------------------------------------------------------------
Key: HBASE-3633
URL: https://issues.apache.org/jira/browse/HBASE-3633
Project: HBase
Issue Type: Bug
Components: zookeeper
Affects Versions: 0.90.1
Reporter: Guanpeng Xu
This is a typo. The predicate tests for the wrong answer. Please see the patch, which is clear.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HBASE-3633) ZKUtil::createSetData should only
create a node when it nonexists
Posted by "Guanpeng Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guanpeng Xu updated HBASE-3633:
-------------------------------
Status: Patch Available (was: Open)
I'm sorry for the previous improper patch. I'm not familiar with this system yet.
{code:title=patch|borderStyle=solid}
*** ZKUtil.java~ 2011-02-09 08:23:12.000000000 +0800
--- ZKUtil.java 2011-03-14 17:12:33.000000000 +0800
***************
*** 723,729 ****
public static void createSetData(final ZooKeeperWatcher zkw, final String znode,
final byte [] data)
throws KeeperException {
! if (checkExists(zkw, znode) != -1) {
ZKUtil.createWithParents(zkw, znode);
}
ZKUtil.setData(zkw, znode, data);
--- 723,729 ----
public static void createSetData(final ZooKeeperWatcher zkw, final String znode,
final byte [] data)
throws KeeperException {
! if (checkExists(zkw, znode) == -1) {
ZKUtil.createWithParents(zkw, znode);
}
ZKUtil.setData(zkw, znode, data);
{code}
> ZKUtil::createSetData should only create a node when it nonexists
> -----------------------------------------------------------------
>
> Key: HBASE-3633
> URL: https://issues.apache.org/jira/browse/HBASE-3633
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.1
> Reporter: Guanpeng Xu
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> This is a typo. The predicate tests for the wrong answer. Please see the patch, which is clear.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3633) ZKUtil::createSetData should only
create a node when it nonexists
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007865#comment-13007865 ]
Hudson commented on HBASE-3633:
-------------------------------
Integrated in HBase-TRUNK #1792 (See [https://hudson.apache.org/hudson/job/HBase-TRUNK/1792/])
> ZKUtil::createSetData should only create a node when it nonexists
> -----------------------------------------------------------------
>
> Key: HBASE-3633
> URL: https://issues.apache.org/jira/browse/HBASE-3633
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.1
> Reporter: Guanpeng Xu
> Fix For: 0.90.2
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> This is a typo. The predicate tests for the wrong answer. Please see the patch, which is clear.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HBASE-3633) ZKUtil::createSetData should only
create a node when it nonexists
Posted by "Guanpeng Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guanpeng Xu updated HBASE-3633:
-------------------------------
Status: Open (was: Patch Available)
> ZKUtil::createSetData should only create a node when it nonexists
> -----------------------------------------------------------------
>
> Key: HBASE-3633
> URL: https://issues.apache.org/jira/browse/HBASE-3633
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.1
> Reporter: Guanpeng Xu
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> This is a typo. The predicate tests for the wrong answer. Please see the patch, which is clear.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HBASE-3633) ZKUtil::createSetData should only
create a node when it nonexists
Posted by "Guanpeng Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guanpeng Xu updated HBASE-3633:
-------------------------------
Status: Patch Available (was: Open)
*** ZKUtil.java~ 2011-02-09 08:23:12.000000000 +0800
--- ZKUtil.java 2011-03-14 17:12:33.000000000 +0800
***************
*** 723,729 ****
public static void createSetData(final ZooKeeperWatcher zkw, final String znode,
final byte [] data)
throws KeeperException {
! if (checkExists(zkw, znode) != -1) {
ZKUtil.createWithParents(zkw, znode);
}
ZKUtil.setData(zkw, znode, data);
--- 723,729 ----
public static void createSetData(final ZooKeeperWatcher zkw, final String znode,
final byte [] data)
throws KeeperException {
! if (checkExists(zkw, znode) == -1) {
ZKUtil.createWithParents(zkw, znode);
}
ZKUtil.setData(zkw, znode, data);
> ZKUtil::createSetData should only create a node when it nonexists
> -----------------------------------------------------------------
>
> Key: HBASE-3633
> URL: https://issues.apache.org/jira/browse/HBASE-3633
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.1
> Reporter: Guanpeng Xu
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> This is a typo. The predicate tests for the wrong answer. Please see the patch, which is clear.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HBASE-3633) ZKUtil::createSetData should only
create a node when it nonexists
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-3633:
-------------------------
Resolution: Fixed
Fix Version/s: 0.90.2
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Thank you for the patch Guanpeng. Applied to branch and trunk.
> ZKUtil::createSetData should only create a node when it nonexists
> -----------------------------------------------------------------
>
> Key: HBASE-3633
> URL: https://issues.apache.org/jira/browse/HBASE-3633
> Project: HBase
> Issue Type: Bug
> Components: zookeeper
> Affects Versions: 0.90.1
> Reporter: Guanpeng Xu
> Fix For: 0.90.2
>
> Original Estimate: 1m
> Remaining Estimate: 1m
>
> This is a typo. The predicate tests for the wrong answer. Please see the patch, which is clear.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira