You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/27 04:52:03 UTC
[GitHub] [pulsar] SignorMercurio opened a new pull request, #16233: [feature][doc] Add badges for README
SignorMercurio opened a new pull request, #16233:
URL: https://github.com/apache/pulsar/pull/16233
Fixes #15958
### Motivation
Please see https://github.com/apache/pulsar/issues/15538#issuecomment-1126064195 for more info.
### Modifications
Add badges for README. Also formatted README.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API: no
- The schema: no
- The default values of configurations: no
- The wire protocol: no
- The rest endpoints: no
- The admin cli options: no
- Anything that affects deployment: no
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [x] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #16233: [feature][doc] Add badges for README
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #16233:
URL: https://github.com/apache/pulsar/pull/16233#issuecomment-1169341660
@SignorMercurio
1. Should users be navigated to the following websites after clicking the badges?
<img width="984" alt="image" src="https://user-images.githubusercontent.com/50226895/176312466-31329d95-80d5-4d96-a170-270202e02e8c.png">
1️⃣ not sure
2️⃣ https://hub.docker.com/r/apachepulsar/pulsar?
3️⃣ https://github.com/apache/pulsar/graphs/contributors?
4️⃣ https://github.com/apache/pulsar/commits/master
5️⃣ https://pulsar.apache.org/download ?
2. Does it make sense the add the badges in red circles? Users can be navigated to https://pulsar.apache.org/docs/next/ after clicking `docs`
<img width="574" alt="image" src="https://user-images.githubusercontent.com/50226895/176309278-0d9c689e-8827-4052-8e6b-18f366eced5f.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #16233: [feature][doc] Add badges for README
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged PR #16233:
URL: https://github.com/apache/pulsar/pull/16233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] SignorMercurio commented on pull request #16233: [feature][doc] Add badges for README
Posted by GitBox <gi...@apache.org>.
SignorMercurio commented on PR #16233:
URL: https://github.com/apache/pulsar/pull/16233#issuecomment-1169445818
@Anonymitaet
The docs and codecov badges are generated by [shields.io](https://shields.io/) when [Read the Docs](https://readthedocs.org/) and [Codecov](https://docs.codecov.com/docs) are used. I think this project does not utilize these two and therefore it's not suitable to add these two badges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #16233: [feature][doc] Add badges for README
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #16233:
URL: https://github.com/apache/pulsar/pull/16233#issuecomment-1169318579
@SignorMercurio thanks for your contribution! Please @me and @urfreespace to review after submitting a PR, or else we might miss it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] SignorMercurio commented on pull request #16233: [feature][doc] Add badges for README
Posted by GitBox <gi...@apache.org>.
SignorMercurio commented on PR #16233:
URL: https://github.com/apache/pulsar/pull/16233#issuecomment-1169434519
@Anonymitaet
1. My bad, I forgot to add these links. I'll fix this soon.
2. I'll check the codecov status and add these badges.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dave2wave commented on pull request #16233: [feature][doc] Add badges for README
Posted by GitBox <gi...@apache.org>.
dave2wave commented on PR #16233:
URL: https://github.com/apache/pulsar/pull/16233#issuecomment-1169455814
Wrong URL for an ASF release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #16233: [feature][doc] Add badges for README
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #16233:
URL: https://github.com/apache/pulsar/pull/16233#issuecomment-1169507283
> Wrong URL for an ASF release
@dave2wave we use https://github.com/apache/pulsar/releases, is it incorrect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org