You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/28 03:02:17 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #24673: Rename 'resources' arg in Kub op to k8s_resources

uranusjr commented on code in PR #24673:
URL: https://github.com/apache/airflow/pull/24673#discussion_r907984624


##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -112,7 +112,7 @@ class KubernetesPodOperator(BaseOperator):
     :param annotations: non-identifying metadata you can attach to the Pod.
         Can be a large range of data, and can include characters
         that are not permitted by labels.
-    :param resources: resources for the launched pod.
+    :param k8s_resources: resources for the launched pod.

Review Comment:
   Let’s go with `container_resources` then.
   
   @savingoyal Passing `resources` will continue to work, emitting a deprecation warning. You must use the new argument for task mapping, but that doesn’t work right now anyway so nothing is broken.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org