Re: [PR] feat(substrait): generate Substrait function YAML [datafusion]

["vbarua (via GitHub)" <gi...@apache.org>]

vbarua commented on PR #22572:
URL: https://github.com/apache/datafusion/pull/22572#issuecomment-4606100912

   > a configurable API for generating Substrait function YAML from a DataFusion function inventory.
   
   Can I ask what the problem you're trying to solve with this is? It seems like there's a lot of overlap with functions already defined in the upstream.
   
   For example, in your generated inventory you have a function definition for [abs](https://github.com/apache/datafusion/pull/22572/changes#diff-23b502d99c93a30effb9654219b8ede0f979b4f62394b628a43384eaef955a99R694-R767), but that is a function that is already defined in the upstream in [abs](https://github.com/substrait-io/substrait/blob/0dba93b2aeb66cef10576a25200f984945eb3dff/extensions/functions_arithmetic.yaml#L765-L771).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org