You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/26 14:12:22 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #625: Makefile: move INCDIROPT to common place

xiaoxiang781216 commented on issue #625: Makefile: move INCDIROPT to common place
URL: https://github.com/apache/incubator-nuttx/pull/625#issuecomment-604453657
 
 
   > This change effects systems using Cygwin under windows with Windos native toolchain. In that case WINTOOLS will be defined and the -2 option must be used. Has that been verified. This change should not be merged if that test case has not been verified.
   >
   
   Yes, we need improve github/apache to verify the patch for windows cygwin/native/msys2.
    
   > It appears to me that the -w was only removed, breaking all such builds. This is the build configuration that I use Windows Cygwin plus Windows native toolchan and this looks to me like it would break my build.
   > 
   
   -w doesn't lose, I set the -w in tools/Config.mk 
   
   https://github.com/apache/incubator-nuttx/pull/625/files#diff-043fcc977f97645d33de793ab09bd262R99
   
   > I think it should not be merged.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services