You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by resmo <gi...@git.apache.org> on 2015/11/19 13:28:38 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9042: remove unused edithosts....
GitHub user resmo opened a pull request:
https://github.com/apache/cloudstack/pull/1093
CLOUDSTACK-9042: remove unused edithosts.sh
As discovered in CLOUDSTACK-9042, this script contains some issues but
since it was replaced since 4.6, we remove it on master.
Also see #1045.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/resmo/cloudstack fix/CLOUDSTACK-9042-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1093.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1093
----
commit 54593f5b0b7b0585dfa2aac542bdcac840ca4b04
Author: Rene Moser <re...@apache.org>
Date: 2015-11-19T12:22:51Z
CLOUDSTACK-9042: remove unused edithosts.sh
As discovered in CLOUDSTACK-9042, this script contains some issues but
since it was replaced since 4.6, we remove it on master.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9042: remove unused edithosts....
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1093#issuecomment-158050587
@resmo: that file is used by HyperV. I have refactored it and removed the files that have to be removed. Have a look at PR #1084
It was difficult to find because the HyperV Resource had the files all hard-coded.
The change I made is like:
```
final String command = String.format("%s%s %s", "/root/", VRScripts.DHCP, args);
```
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [HOLD] CLOUDSTACK-9042: remove unused edi...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1093#issuecomment-163532209
Hi @resmo
Could you please close this PR? The PR #1084 was already merged. As I mentioned above, the edithosts.txt is used by hyperv.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: [HOLD] CLOUDSTACK-9042: remove unused edi...
Posted by resmo <gi...@git.apache.org>.
Github user resmo closed the pull request at:
https://github.com/apache/cloudstack/pull/1093
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---