You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/11/03 20:53:26 UTC
[GitHub] [solr] calvnce opened a new pull request, #1160: Implement GET allLevels endpoint
calvnce opened a new pull request, #1160:
URL: https://github.com/apache/solr/pull/1160
https://issues.apache.org/jira/browse/[SOLR-15781](https://issues.apache.org/jira/browse/SOLR-15781)
# Description
As mentioned on [SOLR-15781](https://issues.apache.org/jira/browse/SOLR-15781), the v2 API implemented in this PR intends to breach the of the yet to be solved v2 API endpoints.
# Solution
This PR implements a single v2 endpoint:
- - `GET` /api/node/logging/levels`
- The PR contains the code that is still under development. The idea is to confirm is the work is in the direction expected from the contributor.
# Tests
- No tests done
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] calvnce commented on pull request #1160: SOLR-16458: Implement GET allLevels endpoint
Posted by "calvnce (via GitHub)" <gi...@apache.org>.
calvnce commented on PR #1160:
URL: https://github.com/apache/solr/pull/1160#issuecomment-1426182325
Hi, @gerlowskija
It has been a while since I did this PR. I have been doing self-study but it seems I lack some guide. I wish to get a mentor
Would you kindly consider taking me along as your mentee?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #1160: SOLR-16458: Implement GET allLevels endpoint
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #1160:
URL: https://github.com/apache/solr/pull/1160#issuecomment-1499347557
Alright, thanks for getting the ball rolling on this @calvnce ! I pushed up some changes that take your starting point and add the remaining APIs, tests and docs.
Curious if you have any thoughts or if this helps explain anything that was confusing before? Lmk! I'll aim to merge some time next week pending any major review feedback here. (I've credited you in our 'CHANGES.txt' file as 'Calvince Otieno' - let me know if you'd prefer something different.) Thanks again Calvince!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1160: SOLR-16458: Migrate v2 logging APIs to JAX-RS
Posted by "sonatype-lift[bot] (via GitHub)" <gi...@apache.org>.
sonatype-lift[bot] commented on code in PR #1160:
URL: https://github.com/apache/solr/pull/1160#discussion_r1160076457
##########
solr/core/src/java/org/apache/solr/handler/admin/InfoHandler.java:
##########
@@ -169,6 +170,17 @@ public Collection<Api> getApis() {
return List.copyOf(list);
}
+ @Override
+ public Collection<Class<? extends JerseyResource>> getJerseyResources() {
+ final var apis = new ArrayList<Class<? extends JerseyResource>>();
+ apis.addAll(handlers.get("threads").getJerseyResources());
Review Comment:
<picture><img alt="6% of developers fix this issue" src="https://lift.sonatype.com/api/commentimage/fixrate/6/display.svg"></picture>
<b>*NULLPTR_DEREFERENCE:</b>* null (last assigned on line 176) is dereferenced.
---
<details><summary>âšī¸ Expand to see all <b>@sonatype-lift</b> commands</summary>
You can reply with the following commands. For example, reply with ***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| ------------- | ------------- |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this PR |
| `@sonatype-lift exclude <file\|issue\|path\|tool>` | Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see its response.
<sub>[Click here](https://github.com/apps/sonatype-lift/installations/new) to add LiftBot to another repo.</sub></details>
---
<b>Help us improve LIFT! (<i>Sonatype LiftBot external survey</i>)</b>
Was this a good recommendation for you? <sub><small>Answering this survey will not impact your Lift settings.</small></sub>
[â[đ Not relevant](https://www.sonatype.com/lift-comment-rating?comment=480118787&lift_comment_rating=1)â] - [â[đ Won't fix](https://www.sonatype.com/lift-comment-rating?comment=480118787&lift_comment_rating=2)â] - [â[đ Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=480118787&lift_comment_rating=3)â] - [â[đ Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=480118787&lift_comment_rating=4)â] - [â[đ Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=480118787&lift_comment_rating=5)â]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #1160: Implement GET allLevels endpoint
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #1160:
URL: https://github.com/apache/solr/pull/1160#issuecomment-1426163774
Hi @calvnce , thanks for the PR!
At a glance I agree with David - this "resource" file is a great start but we'll need to register this somewhere for it to actually get detected and wired-up at runtime. Typically this works by linking the V2 API to the v1 "RequestHandler". RequestHandlers have a `getJerseyResources` method for this purpose. (See the example [here](https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java#L2220) for reference, which links the AddReplicaPropertyAPI to CollectionsHandler.)
For the API you're addressing in this PR, you'd need to add a similar `getJerseyResources` method to Solr's `LoggingHandler` class.
Let me know if there's anything else I can do to help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #1160: Implement GET allLevels endpoint
Posted by GitBox <gi...@apache.org>.
dsmiley commented on PR #1160:
URL: https://github.com/apache/solr/pull/1160#issuecomment-1302673179
Hi Calvnce. I guess you're off to a good start but obviously more to do. You have a new source file here but nothing calls it; I don't think Solr uses any auto-registration based on scanning annotations (as some platforms might do). For example AddReplicaPropertyAPI is registered in CollectionsHandler. You'll want to test this of course, both an automated test but actually try it. I recommend looking at other recent PRs pertaining to the V2 APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija merged pull request #1160: SOLR-16458: Migrate v2 logging APIs to JAX-RS
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #1160:
URL: https://github.com/apache/solr/pull/1160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #1160: SOLR-16458: Implement GET allLevels endpoint
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #1160:
URL: https://github.com/apache/solr/pull/1160#issuecomment-1440488697
My schedule is a little inflexible at this point to set up anything formal, but I'm more than happy to help out as I can! Do you have particular questions about this PR, or APIs in Solr that we can work through here?
Beyond this PR there are some really good resources out there on getting started with Solr. I've actually done some workshops myself on [Getting Started in Solr Contribution](https://www.youtube.com/watch?v=ZgaxXw3P_ds) and even specifically on [v1 and v2 APIs](https://www.youtube.com/watch?v=iIpvfXBjDog) in Solr.
If you're looking for more synchronous help the Solr community has started having monthly virtual "meetups". And we sporadically have "Office Hours" as well to help bootstrap new contributors interested in getting started with the project. Those are usually discussed and scheduled on Solr's "Dev" mailing list that you can find information on [here](https://solr.apache.org/community.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org