You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2017/10/08 15:38:58 UTC

[GitHub] storm pull request #2361: STORM-2698: Upgrade to latest Mockito and Hamcrest

GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/2361

    STORM-2698: Upgrade to latest Mockito and Hamcrest

    See https://issues.apache.org/jira/browse/STORM-2698.
    
    This is based on https://github.com/apache/storm/pull/2360, so please ignore the first commit. Will rebase once that PR is done.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm STORM-2698-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2361.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2361
    
----
commit 370a631857a2b510a1d4de2870ded09598394aa9
Author: Stig Rohde Døssing <sr...@apache.org>
Date:   2017-08-20T16:59:12Z

    STORM-2716: Fix logviewer on Windows, and make storm-webapp tests pass on Windows. Get rid of various constants that were duplicating File.separator and File.pathSeparator.

commit 1067cf8232178ecf1a2e6bdcbf70dab91e9d9805
Author: Stig Rohde Døssing <sr...@apache.org>
Date:   2017-10-07T23:19:26Z

    STORM-2698: Upgrade Mockito and Hamcrest to latest versions

----


---

[GitHub] storm issue #2361: STORM-2698: Upgrade to latest Mockito and Hamcrest

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2361
  
    +1 Please rebase this PR to latest master.


---

[GitHub] storm issue #2361: STORM-2698: Upgrade to latest Mockito and Hamcrest

Posted by srdo <gi...@git.apache.org>.

Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2361
  
    Thanks for review @HeartSaVioR. Merged to master.


---

[GitHub] storm pull request #2361: STORM-2698: Upgrade to latest Mockito and Hamcrest

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2361


---