You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AlexanderShoshin <gi...@git.apache.org> on 2017/03/30 11:42:37 UTC
[GitHub] zeppelin pull request #2206: [ZEPPELIN-1856] Flaky Test: InterpreterRestApiT...
GitHub user AlexanderShoshin opened a pull request:
https://github.com/apache/zeppelin/pull/2206
[ZEPPELIN-1856] Flaky Test: InterpreterRestApiTest.testRestartInterpreterPerNote
### What is this PR for?
A _NullPointerException_ occurs occasionally in `InterpreterRestApiTest.testRestartInterpreterPerNote()` test when `p.getResult()` returns _null_ in the following line of test method:
```
assertEquals(p.getResult().message().get(0).getData(), getSimulatedMarkdownResult("markdown"));
```
It happens when we recieve an _OUTPUT_UPDATE_ALL_ event in _RemoteInterpreterEventPoller_ after `RemoteInterpreter.interpret(..)` is done. The `Paragraph.result` which already contains its final value is setted to _null_ by `NotebookServer.onOutputClear(..)` method. As a result we recieve a _NPE_ in assertion.
### What type of PR is it?
Bug Fix
### Todos
* [ ] - To fix this issue we need to ignore an _OUTPUT_UPDATE_ALL_ event after job is finished.
### What is the Jira issue?
[ZEPPELIN-1856](https://issues.apache.org/jira/browse/ZEPPELIN-1856)
### Questions:
* Does the licenses files need update? **no**
* Is there breaking changes for older versions? **no**
* Does this needs documentation? **no**
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AlexanderShoshin/zeppelin ZEPPELIN-1856
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2206.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2206
----
commit bcf01bd999fc853e08058a77443153338f85c5d4
Author: Alexander Shoshin <al...@epam.com>
Date: 2017-03-24T13:27:35Z
do not clear a paragraph output if the paragraph is already done
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2206: [ZEPPELIN-1856] Flaky Test: InterpreterRestApiT...
Posted by AlexanderShoshin <gi...@git.apache.org>.
Github user AlexanderShoshin closed the pull request at:
https://github.com/apache/zeppelin/pull/2206
---
[GitHub] zeppelin issue #2206: [ZEPPELIN-1856] Flaky Test: InterpreterRestApiTest.tes...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2206
Can you fix it to fit with current master as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2206: [ZEPPELIN-1856] Flaky Test: InterpreterRestApiTest.tes...
Posted by AlexanderShoshin <gi...@git.apache.org>.
Github user AlexanderShoshin commented on the issue:
https://github.com/apache/zeppelin/pull/2206
Hi @jongyoul,
I've added a test for my changes but it won't run until we restore second Travis job which should start all core tests.
I will write when the test will be able to run on Travis.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2206: [ZEPPELIN-1856] Flaky Test: InterpreterRestApiTest.tes...
Posted by AlexanderShoshin <gi...@git.apache.org>.
Github user AlexanderShoshin commented on the issue:
https://github.com/apache/zeppelin/pull/2206
Sure, I'll do it.
But first I need to make some refactoring of `Note.java` class in separate PR. We need to be able to add a custom `Paragraph` to `Note`. This will allow to use a `Paragraph` which we can control while performing. So we will be able to catch `Paragraph` _RUNNING_ and _FINISHED_ phases in a test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2206: [ZEPPELIN-1856] Flaky Test: InterpreterRestApiTest.tes...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2206
Can you make a test in case OUTPUT_UPDATE_ALL is passed after job is done?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2206: [ZEPPELIN-1856] Flaky Test: InterpreterRestApiTest.tes...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/2206
@AlexanderShoshin Can you rebase it from current master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2206: [ZEPPELIN-1856] Flaky Test: InterpreterRestApiTest.tes...
Posted by AlexanderShoshin <gi...@git.apache.org>.
Github user AlexanderShoshin commented on the issue:
https://github.com/apache/zeppelin/pull/2206
@jongyoul it looks like I need to correct my unit tests due last changes in master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---