[GitHub] rhtyd commented on a change in pull request #2223: CLOUDSTACK-10031: change default configuration for router.aggregation?

[gi...@git.apache.org]

rhtyd commented on a change in pull request #2223: CLOUDSTACK-10031: change default configuration for router.aggregation?
URL: https://github.com/apache/cloudstack/pull/2223#discussion_r131469959
 
 

 ##########
 File path: setup/db/db/schema-430to440.sql
 ##########
 @@ -788,7 +788,7 @@ ALTER TABLE `cloud`.`network_offerings` ADD COLUMN supports_streched_l2 boolean
 ALTER TABLE `cloud`.`networks` ADD COLUMN streched_l2 boolean default false;
 ALTER TABLE `cloud`.`vpc` ADD COLUMN region_level_vpc boolean default false;
 INSERT INTO `cloud`.`configuration`(category, instance, component, name, value, description, default_value) VALUES ('Advanced', 'DEFAULT', 'NetworkOrchestrationService', 'router.redundant.vrrp.interval', '1', 'seconds between VRRP broadcast. It would 3 times broadcast fail to trigger fail-over mechanism of redundant router', '1') ON DUPLICATE KEY UPDATE category='Advanced';
-INSERT INTO `cloud`.`configuration`(category, instance, component, name, value, description, default_value) VALUES ('Advanced', 'DEFAULT', 'NetworkOrchestrationService', 'router.aggregation.command.each.timeout', '3', 'timeout in seconds for each Virtual Router command being aggregated. The final aggregation command timeout would be determined by this timeout * commands counts ', '3') ON DUPLICATE KEY UPDATE category='Advanced';
+INSERT INTO `cloud`.`configuration`(category, instance, component, name, value, description, default_value) VALUES ('Advanced', 'DEFAULT', 'NetworkOrchestrationService', 'router.aggregation.command.each.timeout', '600', 'timeout in seconds for each Virtual Router command being aggregated. The final aggregation command timeout would be determined by this timeout * commands counts ', '600') ON DUPLICATE KEY UPDATE category='Advanced';
 
 Review comment:
   The SQL changes need to go into 410->411 upgrade sql path, where the inserts need to be modified as `update`s.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services