[GitHub] [spark] cloud-fan commented on a change in pull request #24685: [SPARK-27814][SQL] The cast operation for partition key may push down uncorrect filter, which is fatal.

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #24685: [SPARK-27814][SQL] The cast operation for partition key may push down uncorrect filter, which  is fatal.
URL: https://github.com/apache/spark/pull/24685#discussion_r287687803
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
 ##########
 @@ -675,12 +675,23 @@ private[client] class Shim_v0_13 extends Shim_v0_12 {
     val useAdvanced = SQLConf.get.advancedPartitionPredicatePushdownEnabled
 
     object ExtractAttribute {
+      val partitionKeys = table.getPartitionKeys.asScala.map(_.getName).toSet
+      var castToStr = false
+
       def unapply(expr: Expression): Option[Attribute] = {
         expr match {
-          case attr: Attribute => Some(attr)
+          case attr: Attribute
 
 Review comment:
   can't we simply do `case attr: Attribute if attr.dataType == StringType`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org