You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/29 10:17:57 UTC

[GitHub] [spark] HyukjinKwon commented on pull request #33569: [SPARK-35806][PYTHON][FOLLOW-UP] Mapping the mode argument to pandas in DataFrame.to_csv

HyukjinKwon commented on pull request #33569:
URL: https://github.com/apache/spark/pull/33569#issuecomment-888993796


   @itholic did you really test it in your local? It fails to import:
   
   ```
   
   ======================================================================
   ERROR [2.139s]: test_orc_write (pyspark.pandas.tests.test_dataframe_spark_io.DataFrameSparkIOTest)
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File "/__w/spark/spark/python/pyspark/pandas/tests/test_dataframe_spark_io.py", line 425, in test_orc_write
       expected.to_orc(tmp, mode="overwrite", partition_cols="i32")
     File "/__w/spark/spark/python/pyspark/pandas/frame.py", line 4796, in to_orc
       mode = validate_mode(mode)
   NameError: name 'validate_mode' is not defined
   
   ======================================================================
   ERROR [0.033s]: test_parquet_write (pyspark.pandas.tests.test_dataframe_spark_io.DataFrameSparkIOTest)
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File "/__w/spark/spark/python/pyspark/pandas/tests/test_dataframe_spark_io.py", line 127, in test_parquet_write
       expected.to_parquet(tmp, mode="overwrite", partition_cols="i32")
     File "/__w/spark/spark/python/pyspark/pandas/frame.py", line 4724, in to_parquet
       mode = validate_mode(mode)
   NameError: name 'validate_mode' is not defined
   
   ======================================================================
   ERROR [0.985s]: test_table (pyspark.pandas.tests.test_dataframe_spark_io.DataFrameSparkIOTest)
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File "/__w/spark/spark/python/pyspark/pandas/tests/test_dataframe_spark_io.py", line 168, in test_table
       expected.to_table("test_table", mode="overwrite", partition_cols=["i32", "bhello"])
     File "/__w/spark/spark/python/pyspark/pandas/frame.py", line 4571, in to_table
       mode = validate_mode(mode)
   NameError: name 'validate_mode' is not defined
   
   ----------------------------------------------------------------------
   Ran 8 tests in 20.997s
   
   FAILED (errors=3, skipped=1)
   
   Generating XML reports...
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org