You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2020/06/24 12:59:14 UTC

[commons-statistics] 06/11: Use assertEquals(inf, x) not assertTrue(Double.isInfinte(x))

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git

commit 1d619feea728d6fbb0405c1fa411c83b2699acbd
Author: aherbert <ah...@apache.org>
AuthorDate: Wed Jun 24 12:32:32 2020 +0100

    Use assertEquals(inf, x) not assertTrue(Double.isInfinte(x))
---
 .../commons/statistics/distribution/GumbelDistributionTest.java       | 4 ++--
 .../commons/statistics/distribution/LaplaceDistributionTest.java      | 4 ++--
 .../apache/commons/statistics/distribution/LevyDistributionTest.java  | 2 +-
 .../commons/statistics/distribution/LogisticsDistributionTest.java    | 4 ++--
 .../commons/statistics/distribution/NakagamiDistributionTest.java     | 2 +-
 .../org/apache/commons/statistics/distribution/TDistributionTest.java | 2 +-
 6 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GumbelDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GumbelDistributionTest.java
index 0acdc39..967d1c3 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GumbelDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GumbelDistributionTest.java
@@ -93,8 +93,8 @@ public class GumbelDistributionTest extends ContinuousDistributionAbstractTest {
     @Test
     public void testSupport() {
         final GumbelDistribution d = makeDistribution();
-        Assertions.assertTrue(Double.isInfinite(d.getSupportLowerBound()));
-        Assertions.assertTrue(Double.isInfinite(d.getSupportUpperBound()));
+        Assertions.assertEquals(Double.NEGATIVE_INFINITY, d.getSupportLowerBound());
+        Assertions.assertEquals(Double.POSITIVE_INFINITY, d.getSupportUpperBound());
         Assertions.assertTrue(d.isSupportConnected());
     }
 }
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LaplaceDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LaplaceDistributionTest.java
index 0272cbb..6b811cb 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LaplaceDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LaplaceDistributionTest.java
@@ -92,8 +92,8 @@ public class LaplaceDistributionTest extends ContinuousDistributionAbstractTest
     @Test
     public void testSupport() {
         final LaplaceDistribution d = makeDistribution();
-        Assertions.assertTrue(Double.isInfinite(d.getSupportLowerBound()));
-        Assertions.assertTrue(Double.isInfinite(d.getSupportUpperBound()));
+        Assertions.assertEquals(Double.NEGATIVE_INFINITY, d.getSupportLowerBound());
+        Assertions.assertEquals(Double.POSITIVE_INFINITY, d.getSupportUpperBound());
         Assertions.assertTrue(d.isSupportConnected());
     }
 }
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LevyDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LevyDistributionTest.java
index 7718367..8759a3a 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LevyDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LevyDistributionTest.java
@@ -96,7 +96,7 @@ public class LevyDistributionTest extends ContinuousDistributionAbstractTest {
     public void testSupport() {
         final LevyDistribution d = makeDistribution();
         Assertions.assertEquals(d.getLocation(), d.getSupportLowerBound(), Precision.EPSILON);
-        Assertions.assertTrue(Double.isInfinite(d.getSupportUpperBound()));
+        Assertions.assertEquals(Double.POSITIVE_INFINITY, d.getSupportUpperBound());
         Assertions.assertTrue(d.isSupportConnected());
     }
 }
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LogisticsDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LogisticsDistributionTest.java
index 700dd44..cfdc306 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LogisticsDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LogisticsDistributionTest.java
@@ -89,8 +89,8 @@ public class LogisticsDistributionTest extends ContinuousDistributionAbstractTes
     @Test
     public void testSupport() {
         final LogisticDistribution d = makeDistribution();
-        Assertions.assertTrue(Double.isInfinite(d.getSupportLowerBound()));
-        Assertions.assertTrue(Double.isInfinite(d.getSupportUpperBound()));
+        Assertions.assertEquals(Double.NEGATIVE_INFINITY, d.getSupportLowerBound());
+        Assertions.assertEquals(Double.POSITIVE_INFINITY, d.getSupportUpperBound());
         Assertions.assertTrue(d.isSupportConnected());
     }
 }
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NakagamiDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NakagamiDistributionTest.java
index c6fab0c..9845d0e 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NakagamiDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NakagamiDistributionTest.java
@@ -86,7 +86,7 @@ public class NakagamiDistributionTest extends ContinuousDistributionAbstractTest
     public void testSupport() {
         final NakagamiDistribution d = makeDistribution();
         Assertions.assertEquals(0, d.getSupportLowerBound(), Precision.EPSILON);
-        Assertions.assertTrue(Double.isInfinite(d.getSupportUpperBound()));
+        Assertions.assertEquals(Double.POSITIVE_INFINITY, d.getSupportUpperBound());
         Assertions.assertTrue(d.isSupportConnected());
     }
 }
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/TDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/TDistributionTest.java
index b3af9f5..e19bf07 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/TDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/TDistributionTest.java
@@ -135,7 +135,7 @@ public class TDistributionTest extends ContinuousDistributionAbstractTest {
 
         dist = new TDistribution(1.5);
         Assertions.assertEquals(0, dist.getMean(), tol);
-        Assertions.assertTrue(Double.isInfinite(dist.getVariance()));
+        Assertions.assertEquals(Double.POSITIVE_INFINITY, dist.getVariance());
 
         dist = new TDistribution(5);
         Assertions.assertEquals(0, dist.getMean(), tol);