You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/08/01 02:44:43 UTC

[GitHub] hughhhh commented on a change in pull request #5524: A tagging system for dashboards, charts and queries

hughhhh commented on a change in pull request #5524: A tagging system for dashboards, charts and queries
URL: https://github.com/apache/incubator-superset/pull/5524#discussion_r206741065
 
 

 ##########
 File path: superset/assets/src/explore/components/ExploreChartHeader.jsx
 ##########
 @@ -32,9 +41,22 @@ const propTypes = {
 };
 
 class ExploreChartHeader extends React.PureComponent {
+  constructor(props) {
+    super(props);
+
+    this.fetchTags = fetchTags.bind(this, 'chart', props.chart.id, false);
 
 Review comment:
   Ahh your right I thought there was way for additional params

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org