You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/09/13 03:07:10 UTC

[GitHub] [apisix-go-plugin-runner] spacewander commented on a diff in pull request #104: docs: add container build guide

spacewander commented on code in PR #104:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/104#discussion_r969104695


##########
docs/en/latest/getting-started.md:
##########
@@ -270,3 +272,27 @@ ext-plugin:
 APISIX will treat the plugin runner as a child process of its own, managing its entire lifecycle.
 
 APISIX will automatically assign a unix socket address for the runner to listen to when it starts. environment variables do not need to be set manually.
+
+#### Setting up in container

Review Comment:
   To be honest, we don't suggest people use the go-runner binary directly. That binary is used as an example.
   What about adding a note for this and removing the `make build` command?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org