[GitHub] [ozone] kerneltime commented on a change in pull request #2509: HDDS-5523. Fix multipart upload failure in s3 compatibility tests

[GitBox <gi...@apache.org>]

kerneltime commented on a change in pull request #2509:
URL: https://github.com/apache/ozone/pull/2509#discussion_r685420665



##########
File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java
##########
@@ -858,15 +860,29 @@ private static int parsePartNumberMarker(String partNumberMarker) {
     return partMarker;
   }
 
-  private static long parseOzoneDate(String ozoneDateStr) throws OS3Exception {
+  // If the return is empty, the precondition should be ignored

Review comment:
       Can you please update this comment and others in the method.
   ```suggestion
     // Parses date string and return long representation. Returns an empty if DateStr is null or invalid. Date in the future are considered invalid.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org