You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2018/04/30 18:04:48 UTC
[GitHub] activemq-artemis pull request #2053: ARTEMIS-1838 Fixing AMQP->Core Race on ...
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/2053
ARTEMIS-1838 Fixing AMQP->Core Race on durable property
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-1838
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2053.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2053
----
commit 89ed206f646bfd03d32bace671b1d4f148ff0e72
Author: Clebert Suconic <cl...@...>
Date: 2018-04-27T21:35:36Z
ARTEMIS-1838 Fixing AMQP->Core Race on durable property
----
---
[GitHub] activemq-artemis issue #2053: ARTEMIS-1838 Fixing AMQP->Core Race on durable...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2053
Sh...t :)
---
[GitHub] activemq-artemis issue #2053: ARTEMIS-1838 Fixing AMQP->Core Race on durable...
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2053
@clebertsuconic ok, I was about to fix it myself. I confirmed that the fix does seem to resolve the issue, I can no longer reproduce it here using the test and an external broker or with the smoke test.
---
[GitHub] activemq-artemis issue #2053: ARTEMIS-1838 Fixing AMQP->Core Race on durable...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2053
@tabish121 thanks.. fixed it
---
[GitHub] activemq-artemis issue #2053: ARTEMIS-1838 Fixing AMQP->Core Race on durable...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/2053
@tabish121 fixed again..
---
[GitHub] activemq-artemis issue #2053: ARTEMIS-1838 Fixing AMQP->Core Race on durable...
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/2053
Now you have a checkstyle violation :)
---
[GitHub] activemq-artemis pull request #2053: ARTEMIS-1838 Fixing AMQP->Core Race on ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2053
---
[GitHub] activemq-artemis pull request #2053: ARTEMIS-1838 Fixing AMQP->Core Race on ...
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2053#discussion_r185075306
--- Diff: tests/smoke-tests/src/test/java/org/apache/activemq/artemis/tests/smoke/crossprotocol/MultiThreadConvertTest.java ---
@@ -0,0 +1,173 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.tests.smoke.crossprotocol;
+
+import javax.jms.Connection;
+import javax.jms.DeliveryMode;
+import javax.jms.IllegalStateException;
+import javax.jms.Message;
+import javax.jms.MessageConsumer;
+import javax.jms.MessageProducer;
+import javax.jms.Session;
+import javax.jms.TextMessage;
+import javax.jms.Topic;
+import java.util.HashMap;
+import java.util.UUID;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.api.core.TransportConfiguration;
+import org.apache.activemq.artemis.core.remoting.impl.netty.TransportConstants;
+import org.apache.activemq.artemis.core.server.ActiveMQServer;
+import org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory;
+import org.apache.activemq.artemis.tests.smoke.common.SmokeTestBase;
+import org.apache.qpid.jms.JmsConnectionFactory;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class MultiThreadConvertTest extends SmokeTestBase {
+
+ private static final String SERVER_NAME_0 = "standard";
+
+ private static final Logger LOG = LoggerFactory.getLogger(MultiThreadConvertTest.class);
+
+ protected String queueName = "amqTestQueue1";
+ private SimpleString coreQueue;
--- End diff --
This coreQueue variable is never used and should be removed.
---