You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by mm...@apache.org on 2019/04/04 16:10:55 UTC
[pulsar] branch branch-2.3 updated: Fix the logic of checking of
variables (#3979)
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/branch-2.3 by this push:
new 04099e4 Fix the logic of checking of variables (#3979)
04099e4 is described below
commit 04099e45a3ebb0d90f56445fb7e0c3eea522aed3
Author: Sanjeev Kulkarni <sa...@gmail.com>
AuthorDate: Thu Apr 4 09:10:09 2019 -0700
Fix the logic of checking of variables (#3979)
---
.../org/apache/pulsar/functions/runtime/KubernetesRuntime.java | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntime.java b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntime.java
index 3c0468d..d190f94 100644
--- a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntime.java
+++ b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntime.java
@@ -273,16 +273,14 @@ public class KubernetesRuntime implements Runtime {
@Override
public CompletableFuture<FunctionStatus> getFunctionStatus(int instanceId) {
CompletableFuture<FunctionStatus> retval = new CompletableFuture<>();
- if (instanceId < 0 || instanceId >= stub.length) {
- if (stub == null) {
- retval.completeExceptionally(new RuntimeException("Invalid InstanceId"));
- return retval;
- }
- }
if (stub == null) {
retval.completeExceptionally(new RuntimeException("Not alive"));
return retval;
}
+ if (instanceId < 0 || instanceId >= stub.length) {
+ retval.completeExceptionally(new RuntimeException("Invalid InstanceId"));
+ return retval;
+ }
ListenableFuture<FunctionStatus> response = stub[instanceId].withDeadlineAfter(GRPC_TIMEOUT_SECS, TimeUnit.SECONDS).getFunctionStatus(Empty.newBuilder().build());
Futures.addCallback(response, new FutureCallback<FunctionStatus>() {
@Override