You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Oliver Deakin (JIRA)" <ji...@apache.org> on 2010/02/17 14:19:27 UTC
[jira] Created: (HARMONY-6449) [classlib][instrument] 3 failures in
HelloWorldTest
[classlib][instrument] 3 failures in HelloWorldTest
---------------------------------------------------
Key: HARMONY-6449
URL: https://issues.apache.org/jira/browse/HARMONY-6449
Project: Harmony
Issue Type: Bug
Reporter: Oliver Deakin
Fix For: 6.0M1, 5.0M13
There are 3 failures in org.apache.harmony.tests.java.lang.instrument.HelloWorldTest that fail consistently on both the java 5 and 6 streams:
testHelloWorld - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testHelloWorld(HelloWorldTest.java:56)
testMultiLineValue - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testMultiLineValue(HelloWorldTest.java:75)
testInvalidMultiLineValue - AssertionFailedError: null at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testInvalidMultiLineValue(HelloWorldTest.java:95)
These failures have been discussed on the dev list but are not yet resolved: http://markmail.org/message/owmi365iowmracqo
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6449) [classlib][instrument] 3 failures
in HelloWorldTest
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837998#action_12837998 ]
Mark Hindess commented on HARMONY-6449:
---------------------------------------
I assume this bug is related to the commit r888739 which looks rather odd in that it removes these lines:
- //FIXME VM doesnot support the capbility right now.
- //capabilities.can_redefine_any_class = 1;
but does not fix anything in DRLVM. It looks like the intention is to ask the VM about capabilities but perhaps there is a logic error and it is assume the VM supports it when it doesn't - perhaps the VM even says it does when it doesn't.
Just guessing though.
> [classlib][instrument] 3 failures in HelloWorldTest
> ---------------------------------------------------
>
> Key: HARMONY-6449
> URL: https://issues.apache.org/jira/browse/HARMONY-6449
> Project: Harmony
> Issue Type: Bug
> Reporter: Oliver Deakin
> Fix For: 6.0M2, 5.0M14
>
>
> There are 3 failures in org.apache.harmony.tests.java.lang.instrument.HelloWorldTest that fail consistently on both the java 5 and 6 streams:
> testHelloWorld - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testHelloWorld(HelloWorldTest.java:56)
> testMultiLineValue - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testMultiLineValue(HelloWorldTest.java:75)
> testInvalidMultiLineValue - AssertionFailedError: null at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testInvalidMultiLineValue(HelloWorldTest.java:95)
> These failures have been discussed on the dev list but are not yet resolved: http://markmail.org/message/owmi365iowmracqo
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6449) [classlib][instrument] 3 failures in
HelloWorldTest
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess updated HARMONY-6449:
----------------------------------
Fix Version/s: (was: 5.0M13)
(was: 6.0M1)
5.0M14
6.0M2
Moving to next release as these aren't regressions. The errors from the child processes for me are:
Element was inserted second time in MapEx!
> [classlib][instrument] 3 failures in HelloWorldTest
> ---------------------------------------------------
>
> Key: HARMONY-6449
> URL: https://issues.apache.org/jira/browse/HARMONY-6449
> Project: Harmony
> Issue Type: Bug
> Reporter: Oliver Deakin
> Fix For: 6.0M2, 5.0M14
>
>
> There are 3 failures in org.apache.harmony.tests.java.lang.instrument.HelloWorldTest that fail consistently on both the java 5 and 6 streams:
> testHelloWorld - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testHelloWorld(HelloWorldTest.java:56)
> testMultiLineValue - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testMultiLineValue(HelloWorldTest.java:75)
> testInvalidMultiLineValue - AssertionFailedError: null at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testInvalidMultiLineValue(HelloWorldTest.java:95)
> These failures have been discussed on the dev list but are not yet resolved: http://markmail.org/message/owmi365iowmracqo
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-6449) [classlib][instrument] 3 failures
in HelloWorldTest
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess resolved HARMONY-6449.
-----------------------------------
Resolution: Fixed
This only failed for me on linux/32bit builds running on 32-bit - the same build would work on 64-bit. However, this now passes for me. I wonder what changed. It would be good to find out before closing this.
> [classlib][instrument] 3 failures in HelloWorldTest
> ---------------------------------------------------
>
> Key: HARMONY-6449
> URL: https://issues.apache.org/jira/browse/HARMONY-6449
> Project: Harmony
> Issue Type: Bug
> Reporter: Oliver Deakin
> Fix For: 6.0M2, 5.0M14
>
>
> There are 3 failures in org.apache.harmony.tests.java.lang.instrument.HelloWorldTest that fail consistently on both the java 5 and 6 streams:
> testHelloWorld - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testHelloWorld(HelloWorldTest.java:56)
> testMultiLineValue - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testMultiLineValue(HelloWorldTest.java:75)
> testInvalidMultiLineValue - AssertionFailedError: null at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testInvalidMultiLineValue(HelloWorldTest.java:95)
> These failures have been discussed on the dev list but are not yet resolved: http://markmail.org/message/owmi365iowmracqo
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6449) [classlib][instrument] 3 failures
in HelloWorldTest
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869954#action_12869954 ]
Oliver Deakin commented on HARMONY-6449:
----------------------------------------
I no longer see these tests failing on Windows x86.
> [classlib][instrument] 3 failures in HelloWorldTest
> ---------------------------------------------------
>
> Key: HARMONY-6449
> URL: https://issues.apache.org/jira/browse/HARMONY-6449
> Project: Harmony
> Issue Type: Bug
> Reporter: Oliver Deakin
> Fix For: 6.0M2, 5.0M14
>
>
> There are 3 failures in org.apache.harmony.tests.java.lang.instrument.HelloWorldTest that fail consistently on both the java 5 and 6 streams:
> testHelloWorld - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testHelloWorld(HelloWorldTest.java:56)
> testMultiLineValue - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testMultiLineValue(HelloWorldTest.java:75)
> testInvalidMultiLineValue - AssertionFailedError: null at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testInvalidMultiLineValue(HelloWorldTest.java:95)
> These failures have been discussed on the dev list but are not yet resolved: http://markmail.org/message/owmi365iowmracqo
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6449) [classlib][instrument] 3 failures
in HelloWorldTest
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838192#action_12838192 ]
Regis Xu commented on HARMONY-6449:
-----------------------------------
The there tests are passed with DRLVM on my Linux machine, Ubuntu 9.10.
can_redefine_classes capability is updated to "1" if vm support it (via jvmti->GetPotentialCapabilities) and "can-redefine-classes" property is set "true" in agent jar's "META-INF/MANIFEST.MF".
> [classlib][instrument] 3 failures in HelloWorldTest
> ---------------------------------------------------
>
> Key: HARMONY-6449
> URL: https://issues.apache.org/jira/browse/HARMONY-6449
> Project: Harmony
> Issue Type: Bug
> Reporter: Oliver Deakin
> Fix For: 6.0M2, 5.0M14
>
>
> There are 3 failures in org.apache.harmony.tests.java.lang.instrument.HelloWorldTest that fail consistently on both the java 5 and 6 streams:
> testHelloWorld - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testHelloWorld(HelloWorldTest.java:56)
> testMultiLineValue - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testMultiLineValue(HelloWorldTest.java:75)
> testInvalidMultiLineValue - AssertionFailedError: null at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testInvalidMultiLineValue(HelloWorldTest.java:95)
> These failures have been discussed on the dev list but are not yet resolved: http://markmail.org/message/owmi365iowmracqo
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6449) [classlib][instrument] 3 failures
in HelloWorldTest
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838070#action_12838070 ]
Oliver Deakin commented on HARMONY-6449:
----------------------------------------
I notice that jvmti_capability.cpp defines can_redefine_classes=0 in all modes, indicating that DRLVM does not support class redefinition. I found HARMONY-3305 was raised for this issue but appears never to have been resolved. This could be the reason the tests fail on DRL but pass on the IBM VME (which supports class redefinition).
> [classlib][instrument] 3 failures in HelloWorldTest
> ---------------------------------------------------
>
> Key: HARMONY-6449
> URL: https://issues.apache.org/jira/browse/HARMONY-6449
> Project: Harmony
> Issue Type: Bug
> Reporter: Oliver Deakin
> Fix For: 6.0M2, 5.0M14
>
>
> There are 3 failures in org.apache.harmony.tests.java.lang.instrument.HelloWorldTest that fail consistently on both the java 5 and 6 streams:
> testHelloWorld - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testHelloWorld(HelloWorldTest.java:56)
> testMultiLineValue - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testMultiLineValue(HelloWorldTest.java:75)
> testInvalidMultiLineValue - AssertionFailedError: null at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testInvalidMultiLineValue(HelloWorldTest.java:95)
> These failures have been discussed on the dev list but are not yet resolved: http://markmail.org/message/owmi365iowmracqo
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6449) [classlib][instrument] 3 failures
in HelloWorldTest
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838253#action_12838253 ]
Oliver Deakin commented on HARMONY-6449:
----------------------------------------
Hi Regis - is that x86 or x86_64?
> [classlib][instrument] 3 failures in HelloWorldTest
> ---------------------------------------------------
>
> Key: HARMONY-6449
> URL: https://issues.apache.org/jira/browse/HARMONY-6449
> Project: Harmony
> Issue Type: Bug
> Reporter: Oliver Deakin
> Fix For: 6.0M2, 5.0M14
>
>
> There are 3 failures in org.apache.harmony.tests.java.lang.instrument.HelloWorldTest that fail consistently on both the java 5 and 6 streams:
> testHelloWorld - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testHelloWorld(HelloWorldTest.java:56)
> testMultiLineValue - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testMultiLineValue(HelloWorldTest.java:75)
> testInvalidMultiLineValue - AssertionFailedError: null at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testInvalidMultiLineValue(HelloWorldTest.java:95)
> These failures have been discussed on the dev list but are not yet resolved: http://markmail.org/message/owmi365iowmracqo
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6449) [classlib][instrument] 3 failures
in HelloWorldTest
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838067#action_12838067 ]
Oliver Deakin commented on HARMONY-6449:
----------------------------------------
It doesn't remove the lines, it just moves them later on in the same function including the commented out FIXME. When I revert that commit I get crashes running the HelloWorld tests, after the commit I get the ABORT messages (Element was inserted second time in MapEx!).
It looks like the error line is coming from hashtable.h in drlvm:
if (pr.second)
return &(pr.first->second);
else
{
DIE(( "Element was inserted second time in MapEx!"));
return NULL; // not reachable; to satisfy compiler warning
}
DRLVM is returning can_redefine_any_class as 0 and we're not changing that flag in the instrument code, so that seems ok. However, the MapEx class is only referenced from classloader code, so it's quite likely that class redefinition is causing the problem.
> [classlib][instrument] 3 failures in HelloWorldTest
> ---------------------------------------------------
>
> Key: HARMONY-6449
> URL: https://issues.apache.org/jira/browse/HARMONY-6449
> Project: Harmony
> Issue Type: Bug
> Reporter: Oliver Deakin
> Fix For: 6.0M2, 5.0M14
>
>
> There are 3 failures in org.apache.harmony.tests.java.lang.instrument.HelloWorldTest that fail consistently on both the java 5 and 6 streams:
> testHelloWorld - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testHelloWorld(HelloWorldTest.java:56)
> testMultiLineValue - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testMultiLineValue(HelloWorldTest.java:75)
> testInvalidMultiLineValue - AssertionFailedError: null at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testInvalidMultiLineValue(HelloWorldTest.java:95)
> These failures have been discussed on the dev list but are not yet resolved: http://markmail.org/message/owmi365iowmracqo
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6449) [classlib][instrument] 3 failures
in HelloWorldTest
Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838257#action_12838257 ]
Regis Xu commented on HARMONY-6449:
-----------------------------------
It's on x86
> [classlib][instrument] 3 failures in HelloWorldTest
> ---------------------------------------------------
>
> Key: HARMONY-6449
> URL: https://issues.apache.org/jira/browse/HARMONY-6449
> Project: Harmony
> Issue Type: Bug
> Reporter: Oliver Deakin
> Fix For: 6.0M2, 5.0M14
>
>
> There are 3 failures in org.apache.harmony.tests.java.lang.instrument.HelloWorldTest that fail consistently on both the java 5 and 6 streams:
> testHelloWorld - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testHelloWorld(HelloWorldTest.java:56)
> testMultiLineValue - expected:<0> but was:<3> at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testMultiLineValue(HelloWorldTest.java:75)
> testInvalidMultiLineValue - AssertionFailedError: null at org.apache.harmony.tests.java.lang.instrument.HelloWorldTest.testInvalidMultiLineValue(HelloWorldTest.java:95)
> These failures have been discussed on the dev list but are not yet resolved: http://markmail.org/message/owmi365iowmracqo
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.