You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Ryan Foster (JIRA)" <ji...@apache.org> on 2009/02/20 01:26:01 UTC
[jira] Created: (OFBIZ-2197) Bluelight theme Drop-down Applications
Bar JS fix
Bluelight theme Drop-down Applications Bar JS fix
-------------------------------------------------
Key: OFBIZ-2197
URL: https://issues.apache.org/jira/browse/OFBIZ-2197
Project: OFBiz
Issue Type: Improvement
Components: ALL COMPONENTS
Affects Versions: SVN trunk
Reporter: Ryan Foster
Priority: Minor
Fix For: SVN trunk
This is a relatively simple javascript fix to the bluelight theme for the lack of :hover attribute support in IE6. This method piggybacks on the included Prototype framework by creating a drop down menu class:
var DropDownMenu = Class.create();
DropDownMenu.prototype = {
initialize: function(menuElement) {
menuElement.childElements().each(function(node){
// if there is a submenu
var submenu = $A(node.getElementsByTagName("ul")).first();
if(submenu != null){
// make sub-menu invisible
Element.extend(submenu).setStyle({display: 'none'});
// toggle the visibility of the submenu
node.onmouseover = node.onmouseout = function(){ Element.toggle(submenu); }
}
});
}
};
//initialize the dropdown menu on page load and target the main-navigation and app-navigation divs
Event.observe(window, "load", function(){
var mainmenu = new DropDownMenu($('main-navigation'));
var appmenu = new DropDownMenu($('app-navigation'));
});
I have attached a patch for you to implement. Let me know if you have any questions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (OFBIZ-2197) Bluelight theme Drop-down
Applications Bar JS fix
Posted by "Ryan Foster (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Foster reopened OFBIZ-2197:
--------------------------------
Reopened issue to re-examine the latest patch of CSS changes to the bluelight theme.
> Bluelight theme Drop-down Applications Bar JS fix
> -------------------------------------------------
>
> Key: OFBIZ-2197
> URL: https://issues.apache.org/jira/browse/OFBIZ-2197
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Ryan Foster
> Assignee: David E. Jones
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: bluelight.patch, bluelight.patch, Bluelight1.jpg
>
>
> This is a relatively simple javascript fix to the bluelight theme for the lack of :hover attribute support in IE6. This method piggybacks on the included Prototype framework by creating a drop down menu class:
> var DropDownMenu = Class.create();
> DropDownMenu.prototype = {
> initialize: function(menuElement) {
> menuElement.childElements().each(function(node){
> // if there is a submenu
> var submenu = $A(node.getElementsByTagName("ul")).first();
> if(submenu != null){
> // make sub-menu invisible
> Element.extend(submenu).setStyle({display: 'none'});
> // toggle the visibility of the submenu
> node.onmouseover = node.onmouseout = function(){ Element.toggle(submenu); }
> }
> });
> }
> };
> //initialize the dropdown menu on page load and target the main-navigation and app-navigation divs
> Event.observe(window, "load", function(){
> var mainmenu = new DropDownMenu($('main-navigation'));
> var appmenu = new DropDownMenu($('app-navigation'));
> });
> I have attached a patch for you to implement. Let me know if you have any questions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2197) Bluelight theme Drop-down
Applications Bar JS fix
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David E. Jones reassigned OFBIZ-2197:
-------------------------------------
Assignee: David E. Jones
> Bluelight theme Drop-down Applications Bar JS fix
> -------------------------------------------------
>
> Key: OFBIZ-2197
> URL: https://issues.apache.org/jira/browse/OFBIZ-2197
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Ryan Foster
> Assignee: David E. Jones
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: bluelight.patch, Bluelight1.jpg
>
>
> This is a relatively simple javascript fix to the bluelight theme for the lack of :hover attribute support in IE6. This method piggybacks on the included Prototype framework by creating a drop down menu class:
> var DropDownMenu = Class.create();
> DropDownMenu.prototype = {
> initialize: function(menuElement) {
> menuElement.childElements().each(function(node){
> // if there is a submenu
> var submenu = $A(node.getElementsByTagName("ul")).first();
> if(submenu != null){
> // make sub-menu invisible
> Element.extend(submenu).setStyle({display: 'none'});
> // toggle the visibility of the submenu
> node.onmouseover = node.onmouseout = function(){ Element.toggle(submenu); }
> }
> });
> }
> };
> //initialize the dropdown menu on page load and target the main-navigation and app-navigation divs
> Event.observe(window, "load", function(){
> var mainmenu = new DropDownMenu($('main-navigation'));
> var appmenu = new DropDownMenu($('app-navigation'));
> });
> I have attached a patch for you to implement. Let me know if you have any questions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2197) Bluelight theme Drop-down
Applications Bar JS fix
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675263#action_12675263 ]
David E. Jones commented on OFBIZ-2197:
---------------------------------------
Thank you Ryan, this looks much better and is in SVN rev 746171.
BTW, it seems like there were some CSS changes in your original patch that are not in this patch. Are those needed? If so please attach to this issue and I'll take care of it.
> Bluelight theme Drop-down Applications Bar JS fix
> -------------------------------------------------
>
> Key: OFBIZ-2197
> URL: https://issues.apache.org/jira/browse/OFBIZ-2197
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Ryan Foster
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: bluelight.patch, Bluelight1.jpg
>
>
> This is a relatively simple javascript fix to the bluelight theme for the lack of :hover attribute support in IE6. This method piggybacks on the included Prototype framework by creating a drop down menu class:
> var DropDownMenu = Class.create();
> DropDownMenu.prototype = {
> initialize: function(menuElement) {
> menuElement.childElements().each(function(node){
> // if there is a submenu
> var submenu = $A(node.getElementsByTagName("ul")).first();
> if(submenu != null){
> // make sub-menu invisible
> Element.extend(submenu).setStyle({display: 'none'});
> // toggle the visibility of the submenu
> node.onmouseover = node.onmouseout = function(){ Element.toggle(submenu); }
> }
> });
> }
> };
> //initialize the dropdown menu on page load and target the main-navigation and app-navigation divs
> Event.observe(window, "load", function(){
> var mainmenu = new DropDownMenu($('main-navigation'));
> var appmenu = new DropDownMenu($('app-navigation'));
> });
> I have attached a patch for you to implement. Let me know if you have any questions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2197) Bluelight theme Drop-down Applications
Bar JS fix
Posted by "Ryan Foster (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Foster updated OFBIZ-2197:
-------------------------------
Attachment: bluelight.patch
javascript fix patch for bluelight theme
> Bluelight theme Drop-down Applications Bar JS fix
> -------------------------------------------------
>
> Key: OFBIZ-2197
> URL: https://issues.apache.org/jira/browse/OFBIZ-2197
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Ryan Foster
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: bluelight.patch
>
>
> This is a relatively simple javascript fix to the bluelight theme for the lack of :hover attribute support in IE6. This method piggybacks on the included Prototype framework by creating a drop down menu class:
> var DropDownMenu = Class.create();
> DropDownMenu.prototype = {
> initialize: function(menuElement) {
> menuElement.childElements().each(function(node){
> // if there is a submenu
> var submenu = $A(node.getElementsByTagName("ul")).first();
> if(submenu != null){
> // make sub-menu invisible
> Element.extend(submenu).setStyle({display: 'none'});
> // toggle the visibility of the submenu
> node.onmouseover = node.onmouseout = function(){ Element.toggle(submenu); }
> }
> });
> }
> };
> //initialize the dropdown menu on page load and target the main-navigation and app-navigation divs
> Event.observe(window, "load", function(){
> var mainmenu = new DropDownMenu($('main-navigation'));
> var appmenu = new DropDownMenu($('app-navigation'));
> });
> I have attached a patch for you to implement. Let me know if you have any questions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2197) Bluelight theme Drop-down
Applications Bar JS fix
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678670#action_12678670 ]
Jacques Le Roux commented on OFBIZ-2197:
----------------------------------------
Hi Ryan,
I did not noticed 1st, but since I introduced your changes, in FF (and in IE as well) the options menus are not higlighted anymore when you move the mouse over. Have you an idea on how to fix that ?
Thanks
> Bluelight theme Drop-down Applications Bar JS fix
> -------------------------------------------------
>
> Key: OFBIZ-2197
> URL: https://issues.apache.org/jira/browse/OFBIZ-2197
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Ryan Foster
> Assignee: David E. Jones
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: bluelight.patch, bluelight.patch, Bluelight1.jpg
>
>
> This is a relatively simple javascript fix to the bluelight theme for the lack of :hover attribute support in IE6. This method piggybacks on the included Prototype framework by creating a drop down menu class:
> var DropDownMenu = Class.create();
> DropDownMenu.prototype = {
> initialize: function(menuElement) {
> menuElement.childElements().each(function(node){
> // if there is a submenu
> var submenu = $A(node.getElementsByTagName("ul")).first();
> if(submenu != null){
> // make sub-menu invisible
> Element.extend(submenu).setStyle({display: 'none'});
> // toggle the visibility of the submenu
> node.onmouseover = node.onmouseout = function(){ Element.toggle(submenu); }
> }
> });
> }
> };
> //initialize the dropdown menu on page load and target the main-navigation and app-navigation divs
> Event.observe(window, "load", function(){
> var mainmenu = new DropDownMenu($('main-navigation'));
> var appmenu = new DropDownMenu($('app-navigation'));
> });
> I have attached a patch for you to implement. Let me know if you have any questions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2197) Bluelight theme Drop-down Applications
Bar JS fix
Posted by "Ryan Foster (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Foster updated OFBIZ-2197:
-------------------------------
Attachment: bluelight.patch
CSS style changes to fix issues in IE.
> Bluelight theme Drop-down Applications Bar JS fix
> -------------------------------------------------
>
> Key: OFBIZ-2197
> URL: https://issues.apache.org/jira/browse/OFBIZ-2197
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Ryan Foster
> Assignee: David E. Jones
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: bluelight.patch, bluelight.patch, Bluelight1.jpg
>
>
> This is a relatively simple javascript fix to the bluelight theme for the lack of :hover attribute support in IE6. This method piggybacks on the included Prototype framework by creating a drop down menu class:
> var DropDownMenu = Class.create();
> DropDownMenu.prototype = {
> initialize: function(menuElement) {
> menuElement.childElements().each(function(node){
> // if there is a submenu
> var submenu = $A(node.getElementsByTagName("ul")).first();
> if(submenu != null){
> // make sub-menu invisible
> Element.extend(submenu).setStyle({display: 'none'});
> // toggle the visibility of the submenu
> node.onmouseover = node.onmouseout = function(){ Element.toggle(submenu); }
> }
> });
> }
> };
> //initialize the dropdown menu on page load and target the main-navigation and app-navigation divs
> Event.observe(window, "load", function(){
> var mainmenu = new DropDownMenu($('main-navigation'));
> var appmenu = new DropDownMenu($('app-navigation'));
> });
> I have attached a patch for you to implement. Let me know if you have any questions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2197) Bluelight theme Drop-down Applications
Bar JS fix
Posted by "Ryan Foster (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Foster updated OFBIZ-2197:
-------------------------------
Attachment: Bluelight1.jpg
screenshot of bluelight theme showing <UL> element dynamically hidden with javascript
> Bluelight theme Drop-down Applications Bar JS fix
> -------------------------------------------------
>
> Key: OFBIZ-2197
> URL: https://issues.apache.org/jira/browse/OFBIZ-2197
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Ryan Foster
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: bluelight.patch, Bluelight1.jpg
>
>
> This is a relatively simple javascript fix to the bluelight theme for the lack of :hover attribute support in IE6. This method piggybacks on the included Prototype framework by creating a drop down menu class:
> var DropDownMenu = Class.create();
> DropDownMenu.prototype = {
> initialize: function(menuElement) {
> menuElement.childElements().each(function(node){
> // if there is a submenu
> var submenu = $A(node.getElementsByTagName("ul")).first();
> if(submenu != null){
> // make sub-menu invisible
> Element.extend(submenu).setStyle({display: 'none'});
> // toggle the visibility of the submenu
> node.onmouseover = node.onmouseout = function(){ Element.toggle(submenu); }
> }
> });
> }
> };
> //initialize the dropdown menu on page load and target the main-navigation and app-navigation divs
> Event.observe(window, "load", function(){
> var mainmenu = new DropDownMenu($('main-navigation'));
> var appmenu = new DropDownMenu($('app-navigation'));
> });
> I have attached a patch for you to implement. Let me know if you have any questions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2197) Bluelight theme Drop-down
Applications Bar JS fix
Posted by "Bruno Busco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675542#action_12675542 ]
Bruno Busco commented on OFBIZ-2197:
------------------------------------
Thank you Ryan and David,
I did not have time to look at this until now.
Unfortunately I tried it on IE7 and does not work.
> Bluelight theme Drop-down Applications Bar JS fix
> -------------------------------------------------
>
> Key: OFBIZ-2197
> URL: https://issues.apache.org/jira/browse/OFBIZ-2197
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Ryan Foster
> Assignee: David E. Jones
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: bluelight.patch, Bluelight1.jpg
>
>
> This is a relatively simple javascript fix to the bluelight theme for the lack of :hover attribute support in IE6. This method piggybacks on the included Prototype framework by creating a drop down menu class:
> var DropDownMenu = Class.create();
> DropDownMenu.prototype = {
> initialize: function(menuElement) {
> menuElement.childElements().each(function(node){
> // if there is a submenu
> var submenu = $A(node.getElementsByTagName("ul")).first();
> if(submenu != null){
> // make sub-menu invisible
> Element.extend(submenu).setStyle({display: 'none'});
> // toggle the visibility of the submenu
> node.onmouseover = node.onmouseout = function(){ Element.toggle(submenu); }
> }
> });
> }
> };
> //initialize the dropdown menu on page load and target the main-navigation and app-navigation divs
> Event.observe(window, "load", function(){
> var mainmenu = new DropDownMenu($('main-navigation'));
> var appmenu = new DropDownMenu($('app-navigation'));
> });
> I have attached a patch for you to implement. Let me know if you have any questions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2197) Bluelight theme Drop-down Applications
Bar JS fix
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-2197.
----------------------------------
Resolution: Fixed
Thanks Ryan,
Your patch is in trunk at revision: 747388 .
If someone wants to enchance I suggest to open a new improvement issue
> Bluelight theme Drop-down Applications Bar JS fix
> -------------------------------------------------
>
> Key: OFBIZ-2197
> URL: https://issues.apache.org/jira/browse/OFBIZ-2197
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Ryan Foster
> Assignee: David E. Jones
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: bluelight.patch, bluelight.patch, Bluelight1.jpg
>
>
> This is a relatively simple javascript fix to the bluelight theme for the lack of :hover attribute support in IE6. This method piggybacks on the included Prototype framework by creating a drop down menu class:
> var DropDownMenu = Class.create();
> DropDownMenu.prototype = {
> initialize: function(menuElement) {
> menuElement.childElements().each(function(node){
> // if there is a submenu
> var submenu = $A(node.getElementsByTagName("ul")).first();
> if(submenu != null){
> // make sub-menu invisible
> Element.extend(submenu).setStyle({display: 'none'});
> // toggle the visibility of the submenu
> node.onmouseover = node.onmouseout = function(){ Element.toggle(submenu); }
> }
> });
> }
> };
> //initialize the dropdown menu on page load and target the main-navigation and app-navigation divs
> Event.observe(window, "load", function(){
> var mainmenu = new DropDownMenu($('main-navigation'));
> var appmenu = new DropDownMenu($('app-navigation'));
> });
> I have attached a patch for you to implement. Let me know if you have any questions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2197) Bluelight theme Drop-down Applications
Bar JS fix
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux updated OFBIZ-2197:
-----------------------------------
Issue Type: Bug (was: Improvement)
It was not an improvement but a bug
> Bluelight theme Drop-down Applications Bar JS fix
> -------------------------------------------------
>
> Key: OFBIZ-2197
> URL: https://issues.apache.org/jira/browse/OFBIZ-2197
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Ryan Foster
> Assignee: David E. Jones
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: bluelight.patch, bluelight.patch, Bluelight1.jpg
>
>
> This is a relatively simple javascript fix to the bluelight theme for the lack of :hover attribute support in IE6. This method piggybacks on the included Prototype framework by creating a drop down menu class:
> var DropDownMenu = Class.create();
> DropDownMenu.prototype = {
> initialize: function(menuElement) {
> menuElement.childElements().each(function(node){
> // if there is a submenu
> var submenu = $A(node.getElementsByTagName("ul")).first();
> if(submenu != null){
> // make sub-menu invisible
> Element.extend(submenu).setStyle({display: 'none'});
> // toggle the visibility of the submenu
> node.onmouseover = node.onmouseout = function(){ Element.toggle(submenu); }
> }
> });
> }
> };
> //initialize the dropdown menu on page load and target the main-navigation and app-navigation divs
> Event.observe(window, "load", function(){
> var mainmenu = new DropDownMenu($('main-navigation'));
> var appmenu = new DropDownMenu($('app-navigation'));
> });
> I have attached a patch for you to implement. Let me know if you have any questions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2197) Bluelight theme Drop-down
Applications Bar JS fix
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682657#action_12682657 ]
Jacques Le Roux commented on OFBIZ-2197:
----------------------------------------
Bruno fixed it in r754642
> Bluelight theme Drop-down Applications Bar JS fix
> -------------------------------------------------
>
> Key: OFBIZ-2197
> URL: https://issues.apache.org/jira/browse/OFBIZ-2197
> Project: OFBiz
> Issue Type: Bug
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Ryan Foster
> Assignee: David E. Jones
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: bluelight.patch, bluelight.patch, Bluelight1.jpg
>
>
> This is a relatively simple javascript fix to the bluelight theme for the lack of :hover attribute support in IE6. This method piggybacks on the included Prototype framework by creating a drop down menu class:
> var DropDownMenu = Class.create();
> DropDownMenu.prototype = {
> initialize: function(menuElement) {
> menuElement.childElements().each(function(node){
> // if there is a submenu
> var submenu = $A(node.getElementsByTagName("ul")).first();
> if(submenu != null){
> // make sub-menu invisible
> Element.extend(submenu).setStyle({display: 'none'});
> // toggle the visibility of the submenu
> node.onmouseover = node.onmouseout = function(){ Element.toggle(submenu); }
> }
> });
> }
> };
> //initialize the dropdown menu on page load and target the main-navigation and app-navigation divs
> Event.observe(window, "load", function(){
> var mainmenu = new DropDownMenu($('main-navigation'));
> var appmenu = new DropDownMenu($('app-navigation'));
> });
> I have attached a patch for you to implement. Let me know if you have any questions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2197) Bluelight theme Drop-down
Applications Bar JS fix
Posted by "Ryan Foster (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12676017#action_12676017 ]
Ryan Foster commented on OFBIZ-2197:
------------------------------------
Sorry. Took another look at this. It looks like the javascript was firing just fine, but in the CSS on line 1056, the default style display:none was overriding my dynamic inline attribute fom the class file. I made some CSS style changes to correct this problem, and also moved the function to fire on dom:loaded instead of window:load so that you don't see that flash of the dropdown menu before it is hidden so pronounced. I believe some additional CSS fixes to be made to really get this theme looking good on IE, but at least the dropdown should be fully functional now. Please commit the latest patch. Thanks.
> Bluelight theme Drop-down Applications Bar JS fix
> -------------------------------------------------
>
> Key: OFBIZ-2197
> URL: https://issues.apache.org/jira/browse/OFBIZ-2197
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Ryan Foster
> Assignee: David E. Jones
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: bluelight.patch, bluelight.patch, Bluelight1.jpg
>
>
> This is a relatively simple javascript fix to the bluelight theme for the lack of :hover attribute support in IE6. This method piggybacks on the included Prototype framework by creating a drop down menu class:
> var DropDownMenu = Class.create();
> DropDownMenu.prototype = {
> initialize: function(menuElement) {
> menuElement.childElements().each(function(node){
> // if there is a submenu
> var submenu = $A(node.getElementsByTagName("ul")).first();
> if(submenu != null){
> // make sub-menu invisible
> Element.extend(submenu).setStyle({display: 'none'});
> // toggle the visibility of the submenu
> node.onmouseover = node.onmouseout = function(){ Element.toggle(submenu); }
> }
> });
> }
> };
> //initialize the dropdown menu on page load and target the main-navigation and app-navigation divs
> Event.observe(window, "load", function(){
> var mainmenu = new DropDownMenu($('main-navigation'));
> var appmenu = new DropDownMenu($('app-navigation'));
> });
> I have attached a patch for you to implement. Let me know if you have any questions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2197) Bluelight theme Drop-down
Applications Bar JS fix
Posted by "Ryan Foster (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675395#action_12675395 ]
Ryan Foster commented on OFBIZ-2197:
------------------------------------
The CSS changes in the original patch removed the li:hover entries that are not supported in IE6. I kept them in this time around because, although they are not necessarily needed now that there is a javascript fix that overrides this attribute, it is a good CSS fallback for all browsers except IE6, and hopefully, eventually, nobody will be using IE6 in a year or 2 (or 3!) and this javascript will not be necessary anymore.
Thanks for the quick action on this David.
> Bluelight theme Drop-down Applications Bar JS fix
> -------------------------------------------------
>
> Key: OFBIZ-2197
> URL: https://issues.apache.org/jira/browse/OFBIZ-2197
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Ryan Foster
> Assignee: David E. Jones
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: bluelight.patch, Bluelight1.jpg
>
>
> This is a relatively simple javascript fix to the bluelight theme for the lack of :hover attribute support in IE6. This method piggybacks on the included Prototype framework by creating a drop down menu class:
> var DropDownMenu = Class.create();
> DropDownMenu.prototype = {
> initialize: function(menuElement) {
> menuElement.childElements().each(function(node){
> // if there is a submenu
> var submenu = $A(node.getElementsByTagName("ul")).first();
> if(submenu != null){
> // make sub-menu invisible
> Element.extend(submenu).setStyle({display: 'none'});
> // toggle the visibility of the submenu
> node.onmouseover = node.onmouseout = function(){ Element.toggle(submenu); }
> }
> });
> }
> };
> //initialize the dropdown menu on page load and target the main-navigation and app-navigation divs
> Event.observe(window, "load", function(){
> var mainmenu = new DropDownMenu($('main-navigation'));
> var appmenu = new DropDownMenu($('app-navigation'));
> });
> I have attached a patch for you to implement. Let me know if you have any questions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2197) Bluelight theme Drop-down Applications
Bar JS fix
Posted by "David E. Jones (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David E. Jones closed OFBIZ-2197.
---------------------------------
Resolution: Fixed
> Bluelight theme Drop-down Applications Bar JS fix
> -------------------------------------------------
>
> Key: OFBIZ-2197
> URL: https://issues.apache.org/jira/browse/OFBIZ-2197
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Ryan Foster
> Assignee: David E. Jones
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: bluelight.patch, Bluelight1.jpg
>
>
> This is a relatively simple javascript fix to the bluelight theme for the lack of :hover attribute support in IE6. This method piggybacks on the included Prototype framework by creating a drop down menu class:
> var DropDownMenu = Class.create();
> DropDownMenu.prototype = {
> initialize: function(menuElement) {
> menuElement.childElements().each(function(node){
> // if there is a submenu
> var submenu = $A(node.getElementsByTagName("ul")).first();
> if(submenu != null){
> // make sub-menu invisible
> Element.extend(submenu).setStyle({display: 'none'});
> // toggle the visibility of the submenu
> node.onmouseover = node.onmouseout = function(){ Element.toggle(submenu); }
> }
> });
> }
> };
> //initialize the dropdown menu on page load and target the main-navigation and app-navigation divs
> Event.observe(window, "load", function(){
> var mainmenu = new DropDownMenu($('main-navigation'));
> var appmenu = new DropDownMenu($('app-navigation'));
> });
> I have attached a patch for you to implement. Let me know if you have any questions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2197) Bluelight theme Drop-down
Applications Bar JS fix
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675545#action_12675545 ]
Jacques Le Roux commented on OFBIZ-2197:
----------------------------------------
Same issue on IE8
> Bluelight theme Drop-down Applications Bar JS fix
> -------------------------------------------------
>
> Key: OFBIZ-2197
> URL: https://issues.apache.org/jira/browse/OFBIZ-2197
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
> Affects Versions: SVN trunk
> Reporter: Ryan Foster
> Assignee: David E. Jones
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: bluelight.patch, Bluelight1.jpg
>
>
> This is a relatively simple javascript fix to the bluelight theme for the lack of :hover attribute support in IE6. This method piggybacks on the included Prototype framework by creating a drop down menu class:
> var DropDownMenu = Class.create();
> DropDownMenu.prototype = {
> initialize: function(menuElement) {
> menuElement.childElements().each(function(node){
> // if there is a submenu
> var submenu = $A(node.getElementsByTagName("ul")).first();
> if(submenu != null){
> // make sub-menu invisible
> Element.extend(submenu).setStyle({display: 'none'});
> // toggle the visibility of the submenu
> node.onmouseover = node.onmouseout = function(){ Element.toggle(submenu); }
> }
> });
> }
> };
> //initialize the dropdown menu on page load and target the main-navigation and app-navigation divs
> Event.observe(window, "load", function(){
> var mainmenu = new DropDownMenu($('main-navigation'));
> var appmenu = new DropDownMenu($('app-navigation'));
> });
> I have attached a patch for you to implement. Let me know if you have any questions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.