[GitHub] elibrumbaugh commented on issue #4981: Make time filter more usable

[GitBox <gi...@apache.org>]

elibrumbaugh commented on issue #4981: Make time filter more usable
URL: https://github.com/apache/incubator-superset/pull/4981#issuecomment-391194442
 
 
   ++ Tabs
   ++ condensed padding
   
   I think tabs work great to separate different concepts or types of tasks. As Max pointed out they should be visually consistent. The tabs in the gif look a bit like buttons to me. 
   
   I agree with Chris that "Range" and "Start/End" are confusing since they are both types of ranges. I also view the use of "range" in this context as a type of smart default.
   
   **A few thoughts:**
   
   - Regardless of what route we take, we should improve the label clarity.
   - Could we separate smart defaults into one tab and the user's ability to pick a custom range into another? This would mean moving the current last option from "range" into the second tab.
   - I think the separation illustrated below would help separate the two types of user desire: 1. give me great defaults and 2. give me the ability to customize them when they don't meet my needs.
   
   For example:
   
   **Defaults**
   - [Yesterday]
   - [Last week]
   - [Last month]
   - [Last year]
   
   **Custom**
   - [Last v] [#] [days v]
   - [Start date]
   - [End date]
   
   An open question I have that effects the order of the tabs is what will people use most often? We should order accordingly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org