You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/12 12:11:31 UTC
[GitHub] [flink] pnowojski commented on a change in pull request #8692:
[FLINK-12804] Introduce mailbox-based ExecutorService
pnowojski commented on a change in pull request #8692: [FLINK-12804] Introduce mailbox-based ExecutorService
URL: https://github.com/apache/flink/pull/8692#discussion_r302950335
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -451,7 +451,7 @@ public final void cancel() throws Exception {
cancelTask();
}
finally {
- mailboxProcessor.cancelMailboxExecution();
+ mailboxProcessor.allActionsCompleted();
Review comment:
nit: Regarding the now "non clearing" behaviour. I'm not sure what's better - to have lingering letters in the mailbox that were not processed is kind of weird/inconsistent state. On the other hand for debugging purposes it might be good to know what kind of letters were not processed. Maybe a good compromise would be to clear the mailbox but printout the mailbox content in debug logs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services