[GitHub] [pinot] jtao15 commented on a change in pull request #8071: Improve the proactive segment clean-up for REVERTED

[GitBox <gi...@apache.org>]

jtao15 commented on a change in pull request #8071:
URL: https://github.com/apache/pinot/pull/8071#discussion_r792916768



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
##########
@@ -3038,10 +3042,8 @@ public void revertReplaceSegments(String tableNameWithType, String segmentLineag
           // different after updating the lineage entry.
           sendRoutingTableRebuildMessage(tableNameWithType);
 
-          // Invoke the proactive clean-up for segments that we no longer needs in case 'forceRevert' is enabled
-          if (forceRevert) {

Review comment:
       (nit) Can we add one line in the Javadoc to explain that if `forceRevert = true`, `IN_PROGRESS` lineage entry will be reverted.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org