[GitHub] [spark] xkrogen commented on a change in pull request #35378: [SPARK-38077][SQL] Fix binary compatibility issue with isDeterministic flag

[GitBox <gi...@apache.org>]

xkrogen commented on a change in pull request #35378:
URL: https://github.com/apache/spark/pull/35378#discussion_r796794849



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -371,6 +384,18 @@ case class Invoke(
     }
 
   private lazy val encodedFunctionName = ScalaReflection.encodeFieldNameToIdentifier(functionName)
+  private var isDeterministic: Boolean = true

Review comment:
       +1 to @thesamet 's suggestion
   
   We can also consider cleaning up the legacy/compatibility versions of `this`/`apply` in the next minor release and keeping them around only for patch releases?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org