You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by michaelandrepearce <gi...@git.apache.org> on 2018/02/26 09:33:59 UTC
[GitHub] activemq-artemis pull request #1896: ARTEMIS-1661 Support splitting of broke...
GitHub user michaelandrepearce opened a pull request:
https://github.com/apache/activemq-artemis/pull/1896
ARTEMIS-1661 Support splitting of broker.xml
Support XML standard XInclude thus allowing splitting of the broker.xml
Added test cases with split out config using import.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/michaelandrepearce/activemq-artemis XInclude
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1896.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1896
----
commit 7cc3de427af824367276ec1232e6874e4bf0705b
Author: Michael André Pearce <mi...@...>
Date: 2018-02-26T09:31:21Z
ARTEMIS-1661 Support splitting of broker.xml
Support XML standard XInclude thus allowing splitting of the broker.xml
Added test cases with split out config using import.
----
---
[GitHub] activemq-artemis pull request #1896: ARTEMIS-1661 Support splitting of broke...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1896
---
[GitHub] activemq-artemis issue #1896: ARTEMIS-1661 Support splitting of broker.xml
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1896
@gaohoward Updated docs 👍
---
[GitHub] activemq-artemis issue #1896: ARTEMIS-1661 Support splitting of broker.xml
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1896
@gaohoward you on IRC? want to sync up / chat to avoid duplicating effort.
---
[GitHub] activemq-artemis issue #1896: ARTEMIS-1661 Support splitting of broker.xml
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/1896
@adirubin good point. I'm going to merge this and improve it in a separate commit.
---
[GitHub] activemq-artemis issue #1896: ARTEMIS-1661 Support splitting of broker.xml
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1896
just rebased.
---
[GitHub] activemq-artemis issue #1896: ARTEMIS-1661 Support splitting of broker.xml
Posted by gaohoward <gi...@git.apache.org>.
Github user gaohoward commented on the issue:
https://github.com/apache/activemq-artemis/pull/1896
@michaelandrepearce do you think we should add some documentation for this feature?
---
[GitHub] activemq-artemis issue #1896: ARTEMIS-1661 Support splitting of broker.xml
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1896
@adirubin thats correct, you'll need to "touch" the broker.xml file still, this is very similar to the support for config modularity such as log4j e.g. there also you need to "touch" the log4j.xml still.
---
[GitHub] activemq-artemis issue #1896: ARTEMIS-1661 Support splitting of broker.xml
Posted by adirubin <gi...@git.apache.org>.
Github user adirubin commented on the issue:
https://github.com/apache/activemq-artemis/pull/1896
Hi michaelandrepearce, thanks!
If I'm not mistaken, the server won't monitor the x-included files for changes, which could be a problem.
---