You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nixon Rodrigues <ni...@freestoneinfotech.com> on 2018/04/11 19:23:14 UTC
Review Request 66563: Entity is readable even if there is no
entity-read-classification permission.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66563/
-----------------------------------------------------------
Review request for ranger, Madhan Neethiraj, Mehul Parikh, and Pradeep Agrawal.
Bugs: RANGER-2065
https://issues.apache.org/jira/browse/RANGER-2065
Repository: ranger
Description
-------
This patch includes changes to verify entity-read-classification permission is available for entity resource to given user/ group when entity is associated with classifications.
Diffs
-----
plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java 465b06fb6
Diff: https://reviews.apache.org/r/66563/diff/1/
Testing
-------
Tested user with and without entity-read-classification permission to access entities with and without classification
Thanks,
Nixon Rodrigues
Re: Review Request 66563: Entity is readable even if there is no
entity-read-classification permission.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66563/#review201110
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On April 13, 2018, 6:09 a.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66563/
> -----------------------------------------------------------
>
> (Updated April 13, 2018, 6:09 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj, Mehul Parikh, and Pradeep Agrawal.
>
>
> Bugs: RANGER-2065
> https://issues.apache.org/jira/browse/RANGER-2065
>
>
> Repository: ranger
>
>
> Description
> -------
>
> This patch includes changes to verify entity-read-classification permission is available for entity resource to given user/ group when entity is associated with classifications.
>
>
> Diffs
> -----
>
> plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java 465b06fb6
>
>
> Diff: https://reviews.apache.org/r/66563/diff/3/
>
>
> Testing
> -------
>
> Tested user with and without entity-read-classification permission to access entities with and without classification
>
>
> Thanks,
>
> Nixon Rodrigues
>
>
Re: Review Request 66563: Entity is readable even if there is no
entity-read-classification permission.
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66563/
-----------------------------------------------------------
(Updated April 13, 2018, 6:09 a.m.)
Review request for ranger, Madhan Neethiraj, Mehul Parikh, and Pradeep Agrawal.
Changes
-------
This patch includes whitespace formating changes.
Bugs: RANGER-2065
https://issues.apache.org/jira/browse/RANGER-2065
Repository: ranger
Description
-------
This patch includes changes to verify entity-read-classification permission is available for entity resource to given user/ group when entity is associated with classifications.
Diffs (updated)
-----
plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java 465b06fb6
Diff: https://reviews.apache.org/r/66563/diff/3/
Changes: https://reviews.apache.org/r/66563/diff/2-3/
Testing
-------
Tested user with and without entity-read-classification permission to access entities with and without classification
Thanks,
Nixon Rodrigues
Re: Review Request 66563: Entity is readable even if there is no
entity-read-classification permission.
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66563/
-----------------------------------------------------------
(Updated April 12, 2018, 1:33 p.m.)
Review request for ranger, Madhan Neethiraj, Mehul Parikh, and Pradeep Agrawal.
Changes
-------
This patch includes changes to not log ranger audit log for entity resource who's attributes are null since this authz call is meant for adhoc permission check for Atlas.
Bugs: RANGER-2065
https://issues.apache.org/jira/browse/RANGER-2065
Repository: ranger
Description
-------
This patch includes changes to verify entity-read-classification permission is available for entity resource to given user/ group when entity is associated with classifications.
Diffs (updated)
-----
plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java 465b06fb6
Diff: https://reviews.apache.org/r/66563/diff/2/
Changes: https://reviews.apache.org/r/66563/diff/1-2/
Testing
-------
Tested user with and without entity-read-classification permission to access entities with and without classification
Thanks,
Nixon Rodrigues
Re: Review Request 66563: Entity is readable even if there is no
entity-read-classification permission.
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66563/#review200949
-----------------------------------------------------------
Ship it!
Ship It!
- Qiang Zhang
On April 11, 2018, 7:23 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66563/
> -----------------------------------------------------------
>
> (Updated April 11, 2018, 7:23 p.m.)
>
>
> Review request for ranger, Madhan Neethiraj, Mehul Parikh, and Pradeep Agrawal.
>
>
> Bugs: RANGER-2065
> https://issues.apache.org/jira/browse/RANGER-2065
>
>
> Repository: ranger
>
>
> Description
> -------
>
> This patch includes changes to verify entity-read-classification permission is available for entity resource to given user/ group when entity is associated with classifications.
>
>
> Diffs
> -----
>
> plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java 465b06fb6
>
>
> Diff: https://reviews.apache.org/r/66563/diff/1/
>
>
> Testing
> -------
>
> Tested user with and without entity-read-classification permission to access entities with and without classification
>
>
> Thanks,
>
> Nixon Rodrigues
>
>