You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ki...@apache.org on 2018/11/19 20:48:11 UTC
svn commit: r1846946 - in /poi/trunk/src:
java/org/apache/poi/hssf/eventusermodel/ java/org/apache/poi/hssf/record/
java/org/apache/poi/hssf/usermodel/ java/org/apache/poi/ss/formula/
java/org/apache/poi/ss/formula/eval/ java/org/apache/poi/ss/usermode...
Author: kiwiwings
Date: Mon Nov 19 20:48:10 2018
New Revision: 1846946
URL: http://svn.apache.org/viewvc?rev=1846946&view=rev
Log:
Remove commented out System.out calls / Move DummyGraphics2d to testcase area, as it's not used by production code
Added:
poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/DummyGraphics2d.java
- copied unchanged from r1846945, poi/trunk/src/java/org/apache/poi/hssf/usermodel/DummyGraphics2d.java
Removed:
poi/trunk/src/java/org/apache/poi/hssf/usermodel/DummyGraphics2d.java
Modified:
poi/trunk/src/java/org/apache/poi/hssf/eventusermodel/MissingRecordAwareHSSFListener.java
poi/trunk/src/java/org/apache/poi/hssf/record/UnknownRecord.java
poi/trunk/src/java/org/apache/poi/ss/formula/Formula.java
poi/trunk/src/java/org/apache/poi/ss/formula/FormulaParser.java
poi/trunk/src/java/org/apache/poi/ss/formula/eval/OperandResolver.java
poi/trunk/src/java/org/apache/poi/ss/usermodel/DataFormatter.java
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/Notes.java
Modified: poi/trunk/src/java/org/apache/poi/hssf/eventusermodel/MissingRecordAwareHSSFListener.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/eventusermodel/MissingRecordAwareHSSFListener.java?rev=1846946&r1=1846945&r2=1846946&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/eventusermodel/MissingRecordAwareHSSFListener.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/eventusermodel/MissingRecordAwareHSSFListener.java Mon Nov 19 20:48:10 2018
@@ -94,8 +94,6 @@ public final class MissingRecordAwareHSS
break;
case RowRecord.sid:
RowRecord rowrec = (RowRecord) record;
- //System.out.println("Row " + rowrec.getRowNumber() + " found, first column at "
- // + rowrec.getFirstCol() + " last column at " + rowrec.getLastCol());
// If there's a jump in rows, fire off missing row records
if (lastRowRow + 1 < rowrec.getRowNumber()) {
Modified: poi/trunk/src/java/org/apache/poi/hssf/record/UnknownRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/UnknownRecord.java?rev=1846946&r1=1846945&r2=1846946&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/UnknownRecord.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/UnknownRecord.java Mon Nov 19 20:48:10 2018
@@ -80,13 +80,10 @@ public final class UnknownRecord extends
public UnknownRecord(RecordInputStream in) {
_sid = in.getSid();
_rawData = in.readRemainder();
-// if (false && getBiffName(_sid) == null) {
-// // unknown sids in the range 0x0004-0x0013 are probably 'sub-records' of ObjectRecord
-// // those sids are in a different number space.
-// // TODO - put unknown OBJ sub-records in a different class
-// System.out.println("Unknown record 0x" +
-// Integer.toHexString(_sid).toUpperCase(Locale.ROOT));
-// }
+
+ // TODO - put unknown OBJ sub-records in a different class
+ // unknown sids in the range 0x0004-0x0013 are probably 'sub-records' of ObjectRecord
+ // those sids are in a different number space.
}
/**
Modified: poi/trunk/src/java/org/apache/poi/ss/formula/Formula.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/formula/Formula.java?rev=1846946&r1=1846945&r2=1846946&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/formula/Formula.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/formula/Formula.java Mon Nov 19 20:48:10 2018
@@ -48,19 +48,15 @@ public class Formula {
private Formula(byte[] byteEncoding, int encodedTokenLen) {
_byteEncoding = byteEncoding.clone();
_encodedTokenLen = encodedTokenLen;
-// if (false) { // set to true to eagerly check Ptg decoding
-// LittleEndianByteArrayInputStream in = new LittleEndianByteArrayInputStream(byteEncoding);
-// Ptg.readTokens(encodedTokenLen, in);
-// int nUnusedBytes = _byteEncoding.length - in.getReadIndex();
-// if (nUnusedBytes > 0) {
-// // TODO - this seems to occur when IntersectionPtg is present
-// // This example file "IntersectionPtg.xls"
-// // used by test: TestIntersectionPtg.testReading()
-// // has 10 bytes unused at the end of the formula
-// // 10 extra bytes are just 0x01 and 0x00
-// System.out.println(nUnusedBytes + " unused bytes at end of formula");
-// }
-// }
+
+ // TODO - this seems to occur when IntersectionPtg is present
+ // This example file "IntersectionPtg.xls"
+ // used by test: TestIntersectionPtg.testReading()
+ // has 10 bytes unused at the end of the formula
+ // 10 extra bytes are just 0x01 and 0x00
+ // LittleEndianByteArrayInputStream in = new LittleEndianByteArrayInputStream(byteEncoding);
+ // Ptg.readTokens(encodedTokenLen, in);
+ // int nUnusedBytes = _byteEncoding.length - in.getReadIndex();
}
/**
* Convenience method for {@link #read(int, LittleEndianInput, int)}
Modified: poi/trunk/src/java/org/apache/poi/ss/formula/FormulaParser.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/formula/FormulaParser.java?rev=1846946&r1=1846945&r2=1846946&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/formula/FormulaParser.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/formula/FormulaParser.java Mon Nov 19 20:48:10 2018
@@ -234,7 +234,6 @@ public final class FormulaParser {
_inIntersection = false;
}
_pointer += Character.charCount(look);
- //System.out.println(new StringBuilder("Got char: ").appendCodePoint(look)).toString();
}
private void resetPointer(int ptr) {
_pointer = ptr;
Modified: poi/trunk/src/java/org/apache/poi/ss/formula/eval/OperandResolver.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/formula/eval/OperandResolver.java?rev=1846946&r1=1846945&r2=1846946&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/formula/eval/OperandResolver.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/formula/eval/OperandResolver.java Mon Nov 19 20:48:10 2018
@@ -88,8 +88,7 @@ public final class OperandResolver {
CellRangeAddress range = cell.getArrayFormulaRange();
int relativeRowIndex = cell.getRowIndex() - range.getFirstRow();
int relativeColIndex = cell.getColumnIndex() - range.getFirstColumn();
- //System.out.println("Row: " + relativeRowIndex + " Col: " + relativeColIndex);
-
+
if (ae.isColumn()) {
if (ae.isRow()) {
return ae.getRelativeValue(0, 0);
Modified: poi/trunk/src/java/org/apache/poi/ss/usermodel/DataFormatter.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/usermodel/DataFormatter.java?rev=1846946&r1=1846945&r2=1846946&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/usermodel/DataFormatter.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/usermodel/DataFormatter.java Mon Nov 19 20:48:10 2018
@@ -450,7 +450,6 @@ public class DataFormatter implements Ob
// Strip custom text in quotes and escaped characters for now as it can cause performance problems in fractions.
//String strippedFormatStr = formatStr.replaceAll("\\\\ ", " ").replaceAll("\\\\.", "").replaceAll("\"[^\"]*\"", " ").replaceAll("\\?", "#");
- //System.out.println("formatStr: "+strippedFormatStr);
return new FractionFormat(defaultFractionWholePartFormat, defaultFractionFractionPartFormat);
}
Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/Notes.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/Notes.java?rev=1846946&r1=1846945&r2=1846946&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/Notes.java (original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/record/Notes.java Mon Nov 19 20:48:10 2018
@@ -63,7 +63,6 @@ public final class Notes extends SheetCo
for(int i=0; i<_children.length; i++) {
if(_children[i] instanceof NotesAtom) {
notesAtom = (NotesAtom)_children[i];
- //System.out.println("Found notes for sheet " + notesAtom.getSlideID());
}
if(_children[i] instanceof PPDrawing) {
ppDrawing = (PPDrawing)_children[i];
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org