You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/03/26 10:09:00 UTC

[GitHub] [zeppelin] zjffdu opened a new pull request #4080: [ZEPPELIN-5300] Paragraph pending until timeout when process launcher has already fails

zjffdu opened a new pull request #4080:
URL: https://github.com/apache/zeppelin/pull/4080


   
   ### What is this PR for?
   
   This PR is to exist the waitForReady method earlier when process launcher is failed. Currently it would only exit when launch timeout.
   
   ### What type of PR is it?
   [Improvement ]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5300
   
   ### How should this be tested?
   * CI pass
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu edited a comment on pull request #4080: [ZEPPELIN-5300] Paragraph pending until timeout when process launcher has already failed

Posted by GitBox <gi...@apache.org>.
zjffdu edited a comment on pull request #4080:
URL: https://github.com/apache/zeppelin/pull/4080#issuecomment-878120436






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #4080: [ZEPPELIN-5300] Paragraph pending until timeout when process launcher has already failed

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4080:
URL: https://github.com/apache/zeppelin/pull/4080


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4080: [ZEPPELIN-5300] Paragraph pending until timeout when process launcher has already fails

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4080:
URL: https://github.com/apache/zeppelin/pull/4080#issuecomment-823231757


   testConnectExistOnlineIntpProcess(org.apache.zeppelin.interpreter.launcher.ClusterInterpreterLauncherTest)`
   fails twice in CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4080: [ZEPPELIN-5300] Paragraph pending until timeout when process launcher has already fails

Posted by GitBox <gi...@apache.org>.
cuspymd commented on a change in pull request #4080:
URL: https://github.com/apache/zeppelin/pull/4080#discussion_r602709246



##########
File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/ExecRemoteInterpreterProcess.java
##########
@@ -175,6 +177,7 @@ public void waitForShutdown(int timeout) {
 
     @Override
     public void waitForReady(int timeout) {
+      this.waitForThread = Thread.currentThread();
       synchronized (this) {

Review comment:
       Wouldn't it be better to be inside the synchronized block?
   And is it okay to not assign `this.waitForThread` to null again?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #4080: [ZEPPELIN-5300] Paragraph pending until timeout when process launcher has already failed

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4080:
URL: https://github.com/apache/zeppelin/pull/4080#issuecomment-878120436


   @Reamer Sorry for response late, the root cause is in the yarn-cluster mode, the launcher process may transition to COMPLETED state.  Now I fixed it in this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on a change in pull request #4080: [ZEPPELIN-5300] Paragraph pending until timeout when process launcher has already failed

Posted by GitBox <gi...@apache.org>.
Reamer commented on a change in pull request #4080:
URL: https://github.com/apache/zeppelin/pull/4080#discussion_r629394156



##########
File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/ExecRemoteInterpreterProcess.java
##########
@@ -248,6 +252,11 @@ public void onProcessFailed(ExecuteException e) {
       synchronized (this) {
         notifyAll();

Review comment:
       This `notifyAll()` should wake up the `wait(timetoTimeout);`.
   Any idea why it doesn't work? Maybe you can explain your change a little more.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4080: [ZEPPELIN-5300] Paragraph pending until timeout when process launcher has already fails

Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #4080:
URL: https://github.com/apache/zeppelin/pull/4080#discussion_r616518254



##########
File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/ExecRemoteInterpreterProcess.java
##########
@@ -175,6 +177,7 @@ public void waitForShutdown(int timeout) {
 
     @Override
     public void waitForReady(int timeout) {
+      this.waitForThread = Thread.currentThread();
       synchronized (this) {

Review comment:
       Fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org