[jira] [Commented] (DRILL-7979) Self-Closing XML Tags Cause Schema Change Exceptions

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17391271#comment-17391271 ] 

ASF GitHub Bot commented on DRILL-7979:
---------------------------------------

cgivre opened a new pull request #2283:
URL: https://github.com/apache/drill/pull/2283


   # [DRILL-7979](https://issues.apache.org/jira/browse/DRILL-7979): Self-Closing XML Tags Cause Schema Change Exceptions
   
   ## Description
   Self closing XML tags are dealt with strangely by java's streaming parser.  If you have data where you have one row containing a self closing XML tag foo (<foo/>) but then in the next row `foo` contains a map or other nested field, Drill will throw a schema change exception.  
   This proposed fix causes Drill to ignore self-closing tags unless they have attributes, which allows data like this to be successfully queried.
   
   For instance, prior to this PR, the data below would not work, but now can be successfully queried.
   
   ```xml
   <row>
     <foo/>
     <bar/>
   </row>
   <row>
     <foo>
        <f1>v1</f1>
        <f2>v2</f2>
      </foo>
      <bar/>
   </row>
   
   ```
   
   ## Documentation
   No user facing changes.
   
   ## Testing
   Added additional unit test and tested manually.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Self-Closing XML Tags Cause Schema Change Exceptions
> ----------------------------------------------------
>
>                 Key: DRILL-7979
>                 URL: https://issues.apache.org/jira/browse/DRILL-7979
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Storage - Other
>    Affects Versions: 1.19.0
>            Reporter: Charles Givre
>            Assignee: Charles Givre
>            Priority: Major
>             Fix For: 1.20.0
>
>
> Self closing XML tags are dealt with strangely by java's streaming parser.  If you have data where you have one row containing a self closing XML tag foo (<foo/>) but then in the next row `foo` contains a map or other nested field, Drill will throw a schema change exception.  
> This proposed fix causes Drill to ignore self-closing tags unless they have attributes, which allows data like this to be successfully queried.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)