[jira] Issue Comment Edited: (LUCENE-2769) FilterIndexReader in trunk does not implement getSequentialSubReaders() correctly

["Uwe Schindler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-2769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933722#action_12933722 ] 

Uwe Schindler edited comment on LUCENE-2769 at 11/19/10 3:51 AM:
-----------------------------------------------------------------

In my opinion, LUCENE-2459 should be reverted and all places that can not correctly filter per segment  should use SlowMultiReaderWrapper as superclass (like e.g. MultiPassIndexSplitter) or better simply wrap with SlowMultiReaderWrapper in the ctor:
{code}
ctor() {
  super(SlowMultiReaderWrapper.wrap(in));
}
{code}

      was (Author: thetaphi):
    In my opinion, LUCENE-2459 should be reverted and all places that can not correctly filter per segment  should use SlowMultiReaderWrapper as superclass (like e.g. MultiPassIndexSplitter)
  
> FilterIndexReader in trunk does not implement getSequentialSubReaders() correctly
> ---------------------------------------------------------------------------------
>
>                 Key: LUCENE-2769
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2769
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 4.0
>            Reporter: Uwe Schindler
>         Attachments: LUCENE-2769.patch, LUCENE-2769.patch
>
>
> Since LUCENE-2459, getSequentialSubReaders() in FilterIndexReader returns null, so it returns an atomic reader. But If you call then any of the enum methods, it throws Exception because the underlying reader is not atomic.
> We should move the null-returning method to SlowMultiReaderWrapper and fix FilterIndexReader's default to return in.getSequentialSubReaders(). Ideally an implementation must of course also wrap the sub-readers.
> If we change this we have to look into other Impls like the MultiPassIndexSplitter if we need to add atomicity.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org