You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Pranay Pandey (JIRA)" <ji...@apache.org> on 2009/03/02 11:02:13 UTC
[jira] Created: (OFBIZ-2226) Create new screen with Facility Tab:
"Verify Pick" to allow user to verify a pick.
Create new screen with Facility Tab: "Verify Pick" to allow user to verify a pick.
----------------------------------------------------------------------------------
Key: OFBIZ-2226
URL: https://issues.apache.org/jira/browse/OFBIZ-2226
Project: OFBiz
Issue Type: Sub-task
Components: product
Affects Versions: SVN trunk
Reporter: Pranay Pandey
Priority: Minor
Fix For: SVN trunk
Create new screen with a Facility Tab: "Verify Pick"
1. To be based on the existing Facility -> Packing screens
2. Initial screen the same as for the Facility -> Packing tab, ie a form with orderId and shipGroupSeqId, or with a picklist bin ID.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2226) Create new screen with Facility Tab:
"Verify Pick" to allow user to verify a pick.
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Mayur closed OFBIZ-2226.
------------------------------
Resolution: Fixed
Thanks Akash and Pranay!
Patch is in trunk rev. 761922.
> Create new screen with Facility Tab: "Verify Pick" to allow user to verify a pick.
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-2226
> URL: https://issues.apache.org/jira/browse/OFBIZ-2226
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2226.patch, OFBIZ-2226.patch, OFBIZ-2226.patch, OFBIZ-2226.patch
>
>
> Create new screen with a Facility Tab: "Verify Pick"
> # To be based on the existing Facility -> Packing screens
> # Initial screen the same as for the Facility -> Packing tab, ie a form with orderId and shipGroupSeqId, or with a picklist bin ID.
> # If the item match, then user will click on complete button and status of shipment will be set to picked, then automatically invoice should be created in "INVOICE_IN_PROCESS" status. We can give Link for invoice after shipment status for any particular order is set to "Picked".
> # If user clicks on the "Cancel" button, system cancels any saved data, clears out session data, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2226) Create new screen with Facility Tab:
"Verify Pick" to allow user to verify a pick.
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Mayur reassigned OFBIZ-2226:
----------------------------------
Assignee: Vikas Mayur
> Create new screen with Facility Tab: "Verify Pick" to allow user to verify a pick.
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-2226
> URL: https://issues.apache.org/jira/browse/OFBIZ-2226
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2226.patch
>
>
> Create new screen with a Facility Tab: "Verify Pick"
> # To be based on the existing Facility -> Packing screens
> # Initial screen the same as for the Facility -> Packing tab, ie a form with orderId and shipGroupSeqId, or with a picklist bin ID.
> # If the item match, then user will click on complete button and status of shipment will be set to picked, then automatically invoice should be created in "INVOICE_IN_PROCESS" status. We can give Link for invoice after shipment status for any particular order is set to "Picked".
> # If user clicks on the "Cancel" button, system cancels any saved data, clears out session data, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2226) Create new screen with Facility Tab:
"Verify Pick" to allow user to verify a pick.
Posted by "Akash Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akash Jain updated OFBIZ-2226:
------------------------------
Attachment: OFBIZ-2226.patch
Here is the updated patch after removing trailing white spaces. Thanks again Vikas.
> Create new screen with Facility Tab: "Verify Pick" to allow user to verify a pick.
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-2226
> URL: https://issues.apache.org/jira/browse/OFBIZ-2226
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2226.patch, OFBIZ-2226.patch, OFBIZ-2226.patch, OFBIZ-2226.patch
>
>
> Create new screen with a Facility Tab: "Verify Pick"
> # To be based on the existing Facility -> Packing screens
> # Initial screen the same as for the Facility -> Packing tab, ie a form with orderId and shipGroupSeqId, or with a picklist bin ID.
> # If the item match, then user will click on complete button and status of shipment will be set to picked, then automatically invoice should be created in "INVOICE_IN_PROCESS" status. We can give Link for invoice after shipment status for any particular order is set to "Picked".
> # If user clicks on the "Cancel" button, system cancels any saved data, clears out session data, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2226) Create new screen with Facility Tab:
"Verify Pick" to allow user to verify a pick.
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694985#action_12694985 ]
Pranay Pandey commented on OFBIZ-2226:
--------------------------------------
Thanks Akash for providing patch for this issue.
> Create new screen with Facility Tab: "Verify Pick" to allow user to verify a pick.
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-2226
> URL: https://issues.apache.org/jira/browse/OFBIZ-2226
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2226.patch
>
>
> Create new screen with a Facility Tab: "Verify Pick"
> # To be based on the existing Facility -> Packing screens
> # Initial screen the same as for the Facility -> Packing tab, ie a form with orderId and shipGroupSeqId, or with a picklist bin ID.
> # If the item match, then user will click on complete button and status of shipment will be set to picked, then automatically invoice should be created in "INVOICE_IN_PROCESS" status. We can give Link for invoice after shipment status for any particular order is set to "Picked".
> # If user clicks on the "Cancel" button, system cancels any saved data, clears out session data, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2226) Create new screen with Facility Tab:
"Verify Pick" to allow user to verify a pick.
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695373#action_12695373 ]
Pranay Pandey commented on OFBIZ-2226:
--------------------------------------
Thanks Vikas for reviewing this patch.
Surely these changes will improve it.
> Create new screen with Facility Tab: "Verify Pick" to allow user to verify a pick.
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-2226
> URL: https://issues.apache.org/jira/browse/OFBIZ-2226
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2226.patch, OFBIZ-2226.patch
>
>
> Create new screen with a Facility Tab: "Verify Pick"
> # To be based on the existing Facility -> Packing screens
> # Initial screen the same as for the Facility -> Packing tab, ie a form with orderId and shipGroupSeqId, or with a picklist bin ID.
> # If the item match, then user will click on complete button and status of shipment will be set to picked, then automatically invoice should be created in "INVOICE_IN_PROCESS" status. We can give Link for invoice after shipment status for any particular order is set to "Picked".
> # If user clicks on the "Cancel" button, system cancels any saved data, clears out session data, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2226) Create new screen with Facility Tab:
"Verify Pick" to allow user to verify a pick.
Posted by "Akash Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akash Jain updated OFBIZ-2226:
------------------------------
Attachment: OFBIZ-2226.patch
Implemented as per given description.
Steps for testing:
1) Create a sales order
2) Then Go to "Verify Pick" tab in Facility Manager
2) Enter OrderId or Pick list bin Id
3) Then enter the Product Id and depress on "Verify item"
4) Or select the items which needs to be verified and depress on "Verify items"
5) Then depress on "complete" button
6) Shipment should be created with "SHIPMENT_PICKED" status in Shipment entity
7) Invoice should be generated and its status should be "INVOICE_IN_PROCESS" in Invoice entity.
> Create new screen with Facility Tab: "Verify Pick" to allow user to verify a pick.
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-2226
> URL: https://issues.apache.org/jira/browse/OFBIZ-2226
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2226.patch
>
>
> Create new screen with a Facility Tab: "Verify Pick"
> # To be based on the existing Facility -> Packing screens
> # Initial screen the same as for the Facility -> Packing tab, ie a form with orderId and shipGroupSeqId, or with a picklist bin ID.
> # If the item match, then user will click on complete button and status of shipment will be set to picked, then automatically invoice should be created in "INVOICE_IN_PROCESS" status. We can give Link for invoice after shipment status for any particular order is set to "Picked".
> # If user clicks on the "Cancel" button, system cancels any saved data, clears out session data, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2226) Create new screen with Facility Tab:
"Verify Pick" to allow user to verify a pick.
Posted by "Akash Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akash Jain updated OFBIZ-2226:
------------------------------
Attachment: OFBIZ-2226.patch
Improved map name and few grammatical issue.
> Create new screen with Facility Tab: "Verify Pick" to allow user to verify a pick.
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-2226
> URL: https://issues.apache.org/jira/browse/OFBIZ-2226
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2226.patch, OFBIZ-2226.patch
>
>
> Create new screen with a Facility Tab: "Verify Pick"
> # To be based on the existing Facility -> Packing screens
> # Initial screen the same as for the Facility -> Packing tab, ie a form with orderId and shipGroupSeqId, or with a picklist bin ID.
> # If the item match, then user will click on complete button and status of shipment will be set to picked, then automatically invoice should be created in "INVOICE_IN_PROCESS" status. We can give Link for invoice after shipment status for any particular order is set to "Picked".
> # If user clicks on the "Cancel" button, system cancels any saved data, clears out session data, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2226) Create new screen with Facility Tab:
"Verify Pick" to allow user to verify a pick.
Posted by "Akash Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Akash Jain updated OFBIZ-2226:
------------------------------
Attachment: OFBIZ-2226.patch
Thanks Vikas for valuable suggestions in my patch. I have uploaded the patch with suggested changes.
> Create new screen with Facility Tab: "Verify Pick" to allow user to verify a pick.
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-2226
> URL: https://issues.apache.org/jira/browse/OFBIZ-2226
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2226.patch, OFBIZ-2226.patch, OFBIZ-2226.patch
>
>
> Create new screen with a Facility Tab: "Verify Pick"
> # To be based on the existing Facility -> Packing screens
> # Initial screen the same as for the Facility -> Packing tab, ie a form with orderId and shipGroupSeqId, or with a picklist bin ID.
> # If the item match, then user will click on complete button and status of shipment will be set to picked, then automatically invoice should be created in "INVOICE_IN_PROCESS" status. We can give Link for invoice after shipment status for any particular order is set to "Picked".
> # If user clicks on the "Cancel" button, system cancels any saved data, clears out session data, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2226) Create new screen with Facility Tab:
"Verify Pick" to allow user to verify a pick.
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695369#action_12695369 ]
Vikas Mayur commented on OFBIZ-2226:
------------------------------------
Hi Akash, Patch looks good. Just few changes, I would suggest.
1)
{code}
+ BigDecimal qtyToVerify = BigDecimal.ZERO;
+ BigDecimal qtyToVerified = BigDecimal.ZERO;
+ BigDecimal verifiedQuantity = BigDecimal.ZERO;
+ BigDecimal readyToVerifyQty = BigDecimal.ZERO; {code}
Define this on top of the file and use it. Something like
{code} private static BigDecimal ZERO = BigDecimal.ZERO; {code}
2) NPE can occur at
{code}
+ if ((orderItem.getString("productId")).equals(productId)) {
{code}
instead use
{code} + if (productId.equals(orderItem.getString("productId"))) {{code}
3) Try to use entity names so this
{code} + bin = delegator.findOne("PicklistBin", [picklistBinId : picklistBinId], false); {code}
could be
{code}+ pickListBin = delegator.findOne("PicklistBin", [picklistBinId : picklistBinId], false); {code}
4) Use the secure method for
{code}
+ <menu-item name="VerifyPick" title="Verify Pick">
+ <link target="VerifyPick?facilityId=${facilityId}"/>
+ </menu-item>
{code}
Please see recent commits on how this can be done.
Vikas
> Create new screen with Facility Tab: "Verify Pick" to allow user to verify a pick.
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-2226
> URL: https://issues.apache.org/jira/browse/OFBIZ-2226
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Assignee: Vikas Mayur
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2226.patch, OFBIZ-2226.patch
>
>
> Create new screen with a Facility Tab: "Verify Pick"
> # To be based on the existing Facility -> Packing screens
> # Initial screen the same as for the Facility -> Packing tab, ie a form with orderId and shipGroupSeqId, or with a picklist bin ID.
> # If the item match, then user will click on complete button and status of shipment will be set to picked, then automatically invoice should be created in "INVOICE_IN_PROCESS" status. We can give Link for invoice after shipment status for any particular order is set to "Picked".
> # If user clicks on the "Cancel" button, system cancels any saved data, clears out session data, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2226) Create new screen with Facility Tab:
"Verify Pick" to allow user to verify a pick.
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pranay Pandey updated OFBIZ-2226:
---------------------------------
Description:
Create new screen with a Facility Tab: "Verify Pick"
# To be based on the existing Facility -> Packing screens
# Initial screen the same as for the Facility -> Packing tab, ie a form with orderId and shipGroupSeqId, or with a picklist bin ID.
# If the item match, then user will click on complete button and status of shipment will be set to picked, then automatically invoice should be created in "INVOICE_IN_PROCESS" status. We can give Link for invoice after shipment status for any particular order is set to "Picked".
# If user clicks on the "Cancel" button, system cancels any saved data, clears out session data, etc.
was:
Create new screen with a Facility Tab: "Verify Pick"
1. To be based on the existing Facility -> Packing screens
2. Initial screen the same as for the Facility -> Packing tab, ie a form with orderId and shipGroupSeqId, or with a picklist bin ID.
> Create new screen with Facility Tab: "Verify Pick" to allow user to verify a pick.
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-2226
> URL: https://issues.apache.org/jira/browse/OFBIZ-2226
> Project: OFBiz
> Issue Type: Sub-task
> Components: product
> Affects Versions: SVN trunk
> Reporter: Pranay Pandey
> Priority: Minor
> Fix For: SVN trunk
>
>
> Create new screen with a Facility Tab: "Verify Pick"
> # To be based on the existing Facility -> Packing screens
> # Initial screen the same as for the Facility -> Packing tab, ie a form with orderId and shipGroupSeqId, or with a picklist bin ID.
> # If the item match, then user will click on complete button and status of shipment will be set to picked, then automatically invoice should be created in "INVOICE_IN_PROCESS" status. We can give Link for invoice after shipment status for any particular order is set to "Picked".
> # If user clicks on the "Cancel" button, system cancels any saved data, clears out session data, etc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.