[GitHub] [kafka] bbejeck commented on a diff in pull request #12962: KAFKA-14318: KIP-878, Introduce partition autoscaling configs

[GitBox <gi...@apache.org>]

bbejeck commented on code in PR #12962:
URL: https://github.com/apache/kafka/pull/12962#discussion_r1043422635


##########
streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java:
##########
@@ -1368,6 +1370,20 @@ public void shouldNotEnableAnyOptimizationsWithNoOptimizationConfig() {
         assertEquals(0, configs.size());
     }
 
+    @Test
+    public void shouldEnablePartitionAutoscaling() {
+        props.put("partition.autoscaling.enabled", true);
+        final StreamsConfig config = new StreamsConfig(props);
+        assertTrue(config.getBoolean(PARTITION_AUTOSCALING_ENABLED_CONFIG));
+    }
+
+    @Test
+    public void shouldSetPartitionAutoscalingTimeout() {
+        props.put("partition.autoscaling.timeout.ms", 0L);
+        final StreamsConfig config = new StreamsConfig(props);
+        assertThat(config.getBoolean(PARTITION_AUTOSCALING_TIMEOUT_MS_CONFIG), is(0L));

Review Comment:
   oops! `config.getLong` here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org