You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/06/06 13:21:53 UTC

[GitHub] [hadoop] steveloughran commented on issue #802: HADOOP-16279. S3Guard: Implement time-based (TTL) expiry for entries …

steveloughran commented on issue #802: HADOOP-16279. S3Guard: Implement time-based (TTL) expiry for entries …
URL: https://github.com/apache/hadoop/pull/802#issuecomment-499491092
 
 
   Production code looks OK, with one exception.
   
   The exception: switch to Configuration.getTimeDuration() to read the time in, and make the default value seconds. Users can switch to any other unit they want by changing the suffix. Doing this now avoids the problems encountered when retrofitting other bits of the code (block size) to using more usable configuration values.
   
   test-wise we need to add one which verifies a delete of an expired metadata entry deletes any new raw file. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org